-
Notifications
You must be signed in to change notification settings - Fork 2
[SDK-753] Update sample readme #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: puneet <puneet.verma@skyflow.com>
Samples/README.md
Outdated
| 3. Run | ||
|
|
||
| pod install | ||
| 4. Open the [Validations.xcworkspace](Validations/Validations.xcworkspace) file using xcode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file doesn't exist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validations.xcworkspace does not exists in github repo. It automatically comes when we clone the repo in our local.
| 2. For **Name**, enter "SDK Samples". For Roles, choose **Vault Editor**. | ||
| 3. Click **Create**. Your browser downloads a **credentials.json** file. Keep this file secure. You'll need it to generate bearer tokens. | ||
|
|
||
| ### Create a bearer token generation endpoint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't we create and ship the files for this sample for them instead of forcing them to make the directory and files themselves?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because credentials file will not be in the Samples folder. Here we are using credentials.json file for generating bearer token. Which the user need to keep in the separate folder created bearer-token-generator and this folder will not be in this repo since it is completely node project which is used for generaton of endpoint of token generator.
Samples/README.md
Outdated
|
|
||
| pod install | ||
| 4. Open the [`CollectAndRevealSample.xcworkspace](`CollectAndRevealSample/`CollectAndRevealSample.xcworkspace) file using xcode | ||
| 5. click on build and run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't get this running. Also, Xcode doesn't have a button with the text "build and run" that I could find.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build and run in xcode signifies to a triangular shaped button, when we hover over it, it mentions Build and then run the current schema.
5883e08 to
90e26cf
Compare
No description provided.