Skip to content

Conversation

@eizengan
Copy link
Contributor

@eizengan eizengan commented Jun 26, 2025

Adds the ability to supply all sensible options to the list calls underlying conversations_id and users_id. A couple considerations were made while creating this code:

  • Supplying users_list with include_locale is useless since we will immediately throw away the added locale data when plucking and returning the user's id. As such, it has been excluded.
  • Unlike the other parameters, team_id is not prefixed to avoid collision with parameters intended for parent calls (i.e. is not id_team_id). In fact, using the same team_id with the parent calls seems desirable; it means one cannot look up a user in one team and then look up conversations from that user id in another with e.g.
client.users_conversations(
  user: "@some-user",
  team_id: "T0123456",
  id_team_id: "T987654"
)

@eizengan eizengan force-pushed the eizengan/id_all_list_options branch 2 times, most recently from 63d4548 to bf84668 Compare June 26, 2025 16:21
@eizengan eizengan force-pushed the eizengan/id_all_list_options branch from bf84668 to 5c91fe4 Compare June 26, 2025 16:23
@coveralls
Copy link

Pull Request Test Coverage Report for Build 15907224173

Details

  • 10 of 10 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 90.388%

Totals Coverage Status
Change from base Build 15900812463: 0.003%
Covered Lines: 5915
Relevant Lines: 6544

💛 - Coveralls

@dblock dblock merged commit 4306be0 into slack-ruby:master Jun 26, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants