Skip to content

fix: handle malformed user/view payloads in extract_team_id #1481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saschabuehrle wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Open

fix: handle malformed user/view payloads in extract_team_id #1481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions slack_bolt/request/internals.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,9 +112,9 @@ def extract_team_id(payload: Dict[str, Any]) -> Optional[str]:
if isinstance(payload.get("event"), dict):
return extract_team_id(payload["event"])
if isinstance(payload.get("user"), dict):
return payload["user"]["team_id"]
return payload["user"].get("team_id")
if isinstance(payload.get("view"), dict):
return payload["view"]["team_id"]
return payload["view"].get("team_id")
return None


Expand Down
2 changes: 2 additions & 0 deletions tests/slack_bolt/request/test_internals.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1253,8 +1253,10 @@ def test_extraction_functions_invalid_dict_keys(self):
invalid_payloads = {
"event": {"event": "some_event_type"},
"user": {"user": "U12345"},
"user_missing_team_id": {"user": {"id": "U12345"}},
"team": {"team": "T12345"},
"view": {"view": "V12345"},
"view_missing_team_id": {"view": {"id": "V12345"}},
"message": {"message": "some text"},
"item": {"item": "item_id"},
"function_data": {"function_data": "fd_123"},
Expand Down