Skip to content

refactor(cli-hooks): use optional chaining check to gather project dependencies #2548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zimeg merged 3 commits into from
Apr 13, 2026
+6 −1
Merged

refactor(cli-hooks): use optional chaining check to gather project dependencies #2548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3726c80
fix: normalize line endings to LF and apply Biome lint fixes
KirobotDev Apr 12, 2026
6606fc5
Merge branch 'main' into main
zimeg Apr 13, 2026
c96838e
chore: changeset
zimeg Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/eleven-apples-retire.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@slack/cli-hooks": patch
---

refactor(cli-hooks): use optional chaining check to gather project dependencies
2 changes: 1 addition & 1 deletion packages/cli-hooks/src/check-update.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ async function collectVersionInfo(packageName) {
async function getProjectPackageVersion(packageName) {
const stdout = await execWrapper(`npm list ${packageName} --depth=0 --json`);
const currentVersionOutput = JSON.parse(stdout);
if (!currentVersionOutput.dependencies || !currentVersionOutput.dependencies[packageName]) {
Copy link
Copy Markdown
Member

@zimeg zimeg Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👁️‍🗨️ thought: IMHO the chained pattern is confusing in this statement and might make later changes more difficult.

if (!currentVersionOutput.dependencies?.[packageName]) {
throw new Error(`Failed to gather project information about ${packageName}`);
}
return currentVersionOutput.dependencies[packageName].version;
Expand Down