-
Notifications
You must be signed in to change notification settings - Fork 32
feat: add slack docs search subcommand #433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
f248043
94c8a90
d7bbb84
727d7ce
e1b0d80
4985713
91b5ac5
086b9e5
2bf8133
47613d0
5650feb
671b4c8
0baf948
6c6875e
3317e11
d815e69
1bb0949
2fdee9b
8fd1999
962d75d
fb1c29d
7e615c8
086e69e
b1216f9
e26eab4
2bc9fa7
7a1eacd
f1ca5c3
e89d94d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,168 @@ | ||||||
| // Copyright 2022-2026 Salesforce, Inc. | ||||||
| // | ||||||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||||||
| // you may not use this file except in compliance with the License. | ||||||
| // You may obtain a copy of the License at | ||||||
| // | ||||||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||||||
| // | ||||||
| // Unless required by applicable law or agreed to in writing, software | ||||||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||||||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||||||
| // See the License for the specific language governing permissions and | ||||||
| // limitations under the License. | ||||||
|
|
||||||
| package docs | ||||||
|
|
||||||
| import ( | ||||||
| "encoding/json" | ||||||
| "fmt" | ||||||
| "net/url" | ||||||
| "strings" | ||||||
|
|
||||||
| "github.com/slackapi/slack-cli/internal/shared" | ||||||
| "github.com/slackapi/slack-cli/internal/slackerror" | ||||||
| "github.com/slackapi/slack-cli/internal/slacktrace" | ||||||
| "github.com/slackapi/slack-cli/internal/style" | ||||||
| "github.com/spf13/cobra" | ||||||
| ) | ||||||
|
|
||||||
| func buildDocsSearchURL(query string) string { | ||||||
| encodedQuery := url.QueryEscape(query) | ||||||
| return fmt.Sprintf("%s/search/?q=%s", docsURL, encodedQuery) | ||||||
| } | ||||||
|
|
||||||
| type searchConfig struct { | ||||||
| output string | ||||||
| limit int | ||||||
| } | ||||||
|
|
||||||
| func makeAbsoluteURL(relativeURL string) string { | ||||||
| if strings.HasPrefix(relativeURL, "http") { | ||||||
| return relativeURL | ||||||
| } | ||||||
| return docsURL + relativeURL | ||||||
| } | ||||||
|
|
||||||
| func NewSearchCommand(clients *shared.ClientFactory) *cobra.Command { | ||||||
| cfg := &searchConfig{} | ||||||
|
|
||||||
| cmd := &cobra.Command{ | ||||||
| Use: "search [query]", | ||||||
| Short: "Search Slack developer docs", | ||||||
| Long: strings.Join([]string{ | ||||||
| "Search the Slack developer docs and return results in text, JSON, or browser", | ||||||
| "format.", | ||||||
| }, "\n"), | ||||||
| Example: style.ExampleCommandsf([]style.ExampleCommand{ | ||||||
| { | ||||||
| Meaning: "Search docs and return text results", | ||||||
| Command: "docs search \"Block Kit\"", | ||||||
| }, | ||||||
| { | ||||||
| Meaning: "Search docs and open results in browser", | ||||||
| Command: "docs search \"webhooks\" --output=browser", | ||||||
| }, | ||||||
| { | ||||||
| Meaning: "Search docs with limited JSON results", | ||||||
| Command: "docs search \"api\" --output=json --limit=5", | ||||||
| }, | ||||||
| }), | ||||||
| Args: cobra.MinimumNArgs(1), | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
👾 issue: We might want to default to opening the browser if no arguments are provided?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @zimeg I'm 50/50 on this. if you forget the argument you get yanked into a browser which feels maybe rude? |
||||||
| RunE: func(cmd *cobra.Command, args []string) error { | ||||||
| return runDocsSearchCommand(clients, cmd, args, cfg) | ||||||
| }, | ||||||
| } | ||||||
|
|
||||||
| cmd.Flags().StringVar(&cfg.output, "output", "text", "output format: text, json, browser") | ||||||
| cmd.Flags().IntVar(&cfg.limit, "limit", 20, "maximum number of text or json search results to return") | ||||||
|
|
||||||
| return cmd | ||||||
| } | ||||||
|
|
||||||
| func runDocsSearchCommand(clients *shared.ClientFactory, cmd *cobra.Command, args []string, cfg *searchConfig) error { | ||||||
| ctx := cmd.Context() | ||||||
|
|
||||||
lukegalbraithrussell marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
| query := strings.Join(args, " ") | ||||||
|
|
||||||
| switch cfg.output { | ||||||
| case "json": | ||||||
| searchResponse, err := clients.API().DocsSearch(ctx, query, cfg.limit) | ||||||
| if err != nil { | ||||||
| return err | ||||||
| } | ||||||
|
|
||||||
| for i := range searchResponse.Results { | ||||||
| searchResponse.Results[i].URL = makeAbsoluteURL(searchResponse.Results[i].URL) | ||||||
| } | ||||||
|
|
||||||
| encoder := json.NewEncoder(clients.IO.WriteOut()) | ||||||
| encoder.SetIndent("", " ") | ||||||
| if err := encoder.Encode(searchResponse); err != nil { | ||||||
| return slackerror.New(slackerror.ErrUnableToParseJSON).WithRootCause(err) | ||||||
| } | ||||||
|
|
||||||
| clients.IO.PrintTrace(ctx, slacktrace.DocsSearchSuccess, query) | ||||||
|
|
||||||
| return nil | ||||||
| case "text": | ||||||
| searchResponse, err := clients.API().DocsSearch(ctx, query, cfg.limit) | ||||||
| if err != nil { | ||||||
| return err | ||||||
| } | ||||||
|
|
||||||
| if len(searchResponse.Results) == 0 { | ||||||
| clients.IO.PrintInfo(ctx, false, "\n%s", style.Sectionf(style.TextSection{ | ||||||
| Emoji: "books", | ||||||
| Text: "Docs Search", | ||||||
| Secondary: []string{ | ||||||
| fmt.Sprintf("Found zero results for \"%s\"", query), | ||||||
| }, | ||||||
| })) | ||||||
| clients.IO.PrintTrace(ctx, slacktrace.DocsSearchSuccess, query) | ||||||
| return nil | ||||||
| } | ||||||
|
|
||||||
| clients.IO.PrintInfo(ctx, false, "\n%s", style.Sectionf(style.TextSection{ | ||||||
| Emoji: "books", | ||||||
| Text: "Docs Search", | ||||||
| Secondary: []string{ | ||||||
| fmt.Sprintf("Displaying first %d of %d results for \"%s\"", len(searchResponse.Results), searchResponse.TotalResults, query), | ||||||
| }, | ||||||
| })) | ||||||
|
|
||||||
| for _, result := range searchResponse.Results { | ||||||
| absoluteURL := makeAbsoluteURL(result.URL) | ||||||
| clients.IO.PrintInfo(ctx, false, "%s", style.Sectionf(style.TextSection{ | ||||||
| Emoji: "book", | ||||||
| Text: result.Title, | ||||||
| Secondary: []string{absoluteURL}, | ||||||
| })) | ||||||
| } | ||||||
|
|
||||||
| clients.IO.PrintTrace(ctx, slacktrace.DocsSearchSuccess, query) | ||||||
|
|
||||||
| return nil | ||||||
| case "browser": | ||||||
| docsSearchURL := buildDocsSearchURL(query) | ||||||
|
|
||||||
| clients.IO.PrintInfo(ctx, false, "\n%s", style.Sectionf(style.TextSection{ | ||||||
| Emoji: "books", | ||||||
| Text: "Docs Search", | ||||||
| Secondary: []string{ | ||||||
| docsSearchURL, | ||||||
| }, | ||||||
| })) | ||||||
|
|
||||||
| clients.Browser().OpenURL(docsSearchURL) | ||||||
| clients.IO.PrintTrace(ctx, slacktrace.DocsSearchSuccess, query) | ||||||
|
|
||||||
| return nil | ||||||
| default: | ||||||
| return slackerror.New(slackerror.ErrInvalidFlag).WithMessage( | ||||||
| "Invalid output format: %s", cfg.output, | ||||||
| ).WithRemediation( | ||||||
| "Use one of: text, json, browser", | ||||||
| ) | ||||||
| } | ||||||
| } | ||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔗 praise: This is a nice constant to share I'll claim! Global variables sometimes can give me stress...