Skip to content

chore!: remove deprecated "platform-improvements" feedback survey name #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zimeg wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −20
Open

chore!: remove deprecated "platform-improvements" feedback survey name #465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions cmd/feedback/feedback.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,8 @@ const (

// Supported survey names
const (
SlackCLIFeedback = "slack-cli"
SlackPlatformFeedback = "slack-platform"
SlackPlatformFeedbackDeprecated = "platform-improvements" // DEPRECATED(semver:major)
SlackCLIFeedback = "slack-cli"
SlackPlatformFeedback = "slack-platform"
)

type SurveyConfigInterface interface {
Expand Down Expand Up @@ -241,12 +240,6 @@ func runFeedbackCommand(ctx context.Context, clients *shared.ClientFactory, cmd
return nil
}

// DEPRECATED(semver:major): Support the deprecated survey name for backwards compatibility
if surveyNameFlag == SlackPlatformFeedbackDeprecated {
surveyNameFlag = SlackPlatformFeedback
clients.IO.PrintWarning(ctx, "DEPRECATED: The '--name %s' flag is deprecated; use '--name %s' instead", SlackPlatformFeedbackDeprecated, SlackPlatformFeedback)
}

surveyNames, surveyPromptOptions := initSurveyOpts(ctx, clients, SurveyStore)

if _, ok := SurveyStore[surveyNameFlag]; !ok && surveyNameFlag != "" {
Expand Down
11 changes: 0 additions & 11 deletions cmd/feedback/feedback_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,17 +263,6 @@ func TestShowSurveyMessages(t *testing.T) {

func Test_Feedback_FeedbackCommand(t *testing.T) {
testutil.TableTestCommand(t, testutil.CommandTests{
// DEPRECATED(semver:major): Support the deprecated survey name for backwards compatibility
"supports deprecated --name platform-improvements": {
CmdArgs: []string{"--name", "platform-improvements"},
Setup: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock, cf *shared.ClientFactory) {
setupFeedbackCommandMocks(t, ctx, cm, cf)
},
ExpectedOutputs: []string{
"feedback@slack.com",
"https://docs.slack.dev/developer-support",
},
},
"supports --name slack-cli": {
CmdArgs: []string{"--name", "slack-cli"},
Setup: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock, cf *shared.ClientFactory) {
Expand Down
Loading