Fix invalid regex (fixes #159)#163
Merged
pmattj merged 1 commit intoslackhq:masterfrom Jan 9, 2025
slevithan:regexfix2
Merged
Conversation
This was referenced Dec 17, 2024
Contributor
Author
|
@PranayAgarwal, is anything else needed for this to land? |
PranayAgarwal
approved these changes
Jan 9, 2025
Contributor
|
Hey @slevithan, this looks good. Unfortunately I don't work at Slack/Salesforce anymore and don't have maintainer access to this repo, so my approval doesn't count. 🫤 |
Contributor
|
Let me message some people to try and find you another reviewer. |
pmattj
approved these changes
Jan 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See extended details at #159, but essentially,
\xHHfor values above7Fdoesn't work the same in Oniguruma (the regex engine used for TextMate grammars) as in other flavors of regex. As a result, a standalone unenclosed\xfflike the one corrected here is an invalid UTF-8 encoded byte value, rather than a valid code point value as it would be if using the enclosed version\x{ff}.This error is currently leading to highlighting bugs with some input strings (code points above
FFare not matched by this negated range), and preventing the Hack grammar from working at all with Shiki's JS engine.The adjacent
\x7fthat I also changed was already valid, but I changed it for consistency.Note that this was the only place the invalid
\\x7f-\\xffappeared, but the valid/correct version\\x{7f}-\\x{ff}already appears 28 times in the same file.