feat: strict directive validation at parse time#46
Merged
Conversation
Validate `@timeout`, `@poll`, and `@env` directives during parsing, rejecting malformed values with line-numbered error messages before execution begins. - Add DirectiveError type with structured line/directive/message fields - Validate @timeout (integer >= 0), @poll (integer > 0), @env (KEY=VALUE) - Refactor Timeout/Poll to *int to distinguish unset from explicit zero - Support file-level @timeout in frontmatter (inherited by entries) - ParseFile returns []error for multi-error reporting - Add E2E tests for directive validation - Update SPEC.md with validation rules and file-level @timeout docs Closes #43
- parseFrontmatter now returns []error (was single error) - Replace manual newline trimming with strings.Join in loadAndParse
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate
@timeout,@poll, and@envdirectives during parsing, rejecting malformed values with line-numbered error messages before execution begins.Changes
DirectiveErrortype -- structured error with line number, directive name, message@timeout(int >= 0),@poll(int > 0),@env(KEY=VALUE with non-empty key)*intrefactor --Timeout/Pollchanged to pointer to distinguish unset from zero@timeout-- set in frontmatter, inherited by entries unless overriddenParseFilereturns[]error-- multi-error reporting, all validation errors shown at oncefile.clitest:line N: @directive: message@timeoutdocsCloses #43