feat: capture query parity with asserts + regex capture groups#50
Merged
Conversation
- Refactor types.Capture to structured type (Source, LineNum, Regex) - Fix `line N` capture (was returning full stdout, now extracts Nth line) - Add `lineCount` capture query - Add `stdout regex /pattern/` and `stderr regex /pattern/` captures - Validate regex at parse time for both asserts and captures (fail-fast) - Add verbose-mode warning when regex capture doesn't match - Update SPEC.md with full capture query documentation - Update ROADMAP.md Removed from original issue scope: `exit` and `duration` captures (not needed).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #48
Changes
types.Captureto structured type (Source, LineNum, Regex)line Ncapture (was returning full stdout, now extracts Nth line)lineCountcapture querystdout regex /pattern/andstderr regex /pattern/capturesmatchespredicate constant)Scope changes from issue
Removed (not needed):
exitcapturedurationcaptureTest coverage
ResolveCapture(all paths incl. edge cases)parseCapture(all queries, invalid regex, invalid line number)parseAssert