Fix tamed horses despawning when player moves away

[MCbabel]

Description

Fix tamed horses despawning when the player moves away. This addresses a bug reported on the Discord server where multiple users experienced their tamed horses (including ones with saddles and armor) vanishing after leaving the area.

Changes

Previous Behavior

Tamed horses with saddles, armor, and leads would despawn when the player moved more than 128 blocks away. This caused players to permanently lose their equipped horses.

Root Cause

EntityHorse did not override removeWhenFarAway() and inherited the generic Animal::removeWhenFarAway() which only relies on a wander-distance-based despawn protection mechanism (isDespawnProtected). This mechanism could fail for horses that wandered far enough, regardless of their tamed/equipped status.

In contrast, Wolf and Ocelot already had their own removeWhenFarAway() overrides that checked !isTame(), preventing tamed wolves and cats from despawning. Horses lacked this protection entirely.

New Behavior

Tamed, saddled, leashed, or armored horses will no longer despawn regardless of distance from the player. Wild horses without any equipment still follow the normal despawn rules.

Fix Implementation

Added EntityHorse::removeWhenFarAway() override that returns false (preventing despawn) if any of these conditions are true:

• isTamed() - horse has been tamed by a player
• isSaddled() - horse has a saddle equipped
• isLeashed() - horse is attached to a lead
• getArmorType() > 0 - horse has armor equipped

Otherwise falls back to Animal::removeWhenFarAway() for wild horses.

Related Issues

• Fixes a bug reported on the Discord server ("tamed horses are despawning", reported March 5 by multiple users)

[eh-K]

Cant seem to reproduce the previous behavior but your changes appear to fix the issue completely.