Open
Conversation
Adds the Cancel Join tooltip to the "Connecting to host" progress bar
Contributor
|
that's a cool and really practical feature |
Collaborator
|
Does this also resolve the failed connections freezing the whole game? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Very minor QoL addition to allow cancelling while joining a server (came from the feature-suggestions Discord channel)
Changes
Previous Behavior
Previously when joining a server you have no way of stopping and getting out of the fullscreen progressbar.
Root Cause
If connecting to a server takes a long time you need to wait until the connection fails.
New Behavior
Adds the Cancel Join tooltip and behavior, allowing you to close the connection deliberately.
Fix Implementation
Uses a boolean (
m_bCancelRequested) check in the loop that establishes the connection with the server withinGameNetworkManager.cpp, where the main thread can set the boolean to true. Causing the connection to close.Will also hide the tooltip when it is pressed.
AI Use Disclosure
AI was used as a rubber duck to fix a crash
Related Issues
None