Fix TNT minecart exploding despite 'TNT Explodes' option being turned…#1067
Merged
codeHusky merged 1 commit intosmartcmd:mainfrom Mar 9, 2026
Merged
Fix TNT minecart exploding despite 'TNT Explodes' option being turned…#1067codeHusky merged 1 commit intosmartcmd:mainfrom
codeHusky merged 1 commit intosmartcmd:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is the fix 4J did in TU20 decompiled with IDA
Changes
Previous Behavior
Minecart would explode when the option is off
Root Cause
Design flaw
New Behavior
Minecart only explodes when the option is on
Fix Implementation
This was resolved by comparing the pseudocode of TU20 inside IDA with the source code and seeing what logic changes they did (see the images)
AI Use Disclosure
No AI was used.
Related Issues
I noticed there was already a change for this but the logic and code is not accurate to what 4J did in TU 20 and since I am working on my own version of the December 2014 source with accurate TU changes I decided I would do the change here too.