Custom Skins System Added (full work)#302
Conversation
|
English please. |
|
A skin system was added, where you can press x over any skin and select a custom one |
|
All the comments not being in english will most likely make this not get accepted |
IsraelDXPP
changed the title
Im sorry dont speak english 😕 |
|
I'm doing my best to translate your comments with my rusty spanish 3 knowledge and cross referencing that to chatgpt and gemini. I suggested the changes over in your pull request's comments. |
|
|
||
| if ((w == 64 && h == 32) || (w == 64 && h == 64)) | ||
| { | ||
| // CACHE BUSTING: Si usas el mismo nombre "custom.png", el cache del motor no se refresca. |
There was a problem hiding this comment.
Set to "// CACHE BUSTING: If you use the name "custom.png", the engine cache does not refresh"
| if ((w == 64 && h == 32) || (w == 64 && h == 64)) | ||
| { | ||
| // CACHE BUSTING: Si usas el mismo nombre "custom.png", el cache del motor no se refresca. | ||
| // Usamos un contador para generar IDs únicos (ugcskin00000101.png, 102, etc). |
There was a problem hiding this comment.
Set to: "// We use a counter to generate unique IDs (ugcskin00000101.png, 102, etc.)."
| s_ugcSkinLoadCount++; | ||
|
|
||
| wchar_t textureNameBuf[256]; | ||
| // Formato ugcskinXXXXXXXX.png es obligatorio para que getSkinIdFromPath genere un ID válido. |
There was a problem hiding this comment.
Set to : "// The format ugcskinXXXXXXXX.png is mandatory for getSkinIdFromPath to generate a valid ID."
|
|
||
| wchar_t textureNameBuf[256]; | ||
| // Formato ugcskinXXXXXXXX.png es obligatorio para que getSkinIdFromPath genere un ID válido. | ||
| // Ajustamos el ID para que los bits bajos (0-4) sean 0, respetando el bitmask de UGC. |
There was a problem hiding this comment.
Set to : "// We adjust the ID so that the lower bits (0–4) are 0, respecting the UGC bitmask."
English cm
|
@IsraelDXPP |
English //
|
@EnderActually anterior = after |
IsraelDXPP
changed the title
| if (m_packIndex == SKIN_SELECT_PACK_DEFAULT && m_bUsingCustomSkin) | ||
| { | ||
| m_labelSkinOrigin.setLabel(L"X: Custom Skin"); // Muestra la ayuda visual | ||
| m_labelSkinOrigin.setLabel(L"X: Custom Skin"); // Show visual help |
There was a problem hiding this comment.
This comment is very vague, can you try my suggested comment please?
| swprintf(textureNameBuf, 256, L"ugcskin%08X.png", 0x100 + (s_ugcSkinLoadCount << 5)); | ||
| wstring textureName = textureNameBuf; | ||
|
|
||
| // Limpieza opcional del buffer anterior |
There was a problem hiding this comment.
Set to: "//Optional cleaning of the previous buffer
| app.RemoveMemoryTextureFile(m_selectedSkinPath); | ||
| } | ||
|
|
||
| // 1. Cargar datos en el sistema de archivos en memoria |
There was a problem hiding this comment.
Set to: "// 1. Load data into the in-memory file system"
|
@IsraelDXPP I added all of my English Translations to the comments. |
Thanks |
Fixed |
- Incorporates latest fixes and features from the original repo - Prepares main for new branches/PRsupdates from upstream/main into my fork
|
Don't forget to use |
ok |
|
I'm going to reimplement this later. |
6 participants
A skin system was added. When you press the R key, one of the skins allows you to choose a custom skin.