Project modernization

[ModMaker101]

Description

This replaces all C-style casts in the codebase with their appropriate C++-style equivalent. This improves type safety.

Changes

Previous Behavior

The codebase relied on C-style cases like crazy. The C-style casts lack type safety and can performant multiple types of conversions implicitly.

Root Cause

The original code used C-style cases because they were new/didn't exist when this was written. This over time can make it harder to program especially when it in C++.

New Behavior

Most C=style casts now use their C++ equivalent.

Fix Implementation

• Went through the codebase and replaced most of the C-style casts with C++ ones.

AI Use Disclosure

No.

[ModMaker101]

Dang it why is the boat commit there. Oh well.

[ModMaker101]

Ready to merge.

[EnderActually]

Dang it why is the boat commit there. Oh well.

Should have probably made a separate fork to prevent that.

[void2012]

Please keep the old boat code because we try to achieve feature accuracy

[ModMaker101]

That boat code is from this Pr #615 its a fix I just made a new branch based of my boat fix branch on accident

[ModMaker101]

If you don't mind me asking why did you make the PR a draft?

[void2012]

There are examples where int is used in place of where size_t is used, especially for object sizes, array subscripts and std::wstring::find_* functions. Could you please work on this, too? For the sake of the name of this PR. This may also hunt some obscure bugs.

[void2012]

Also, I think it makes sense to get rid off NULL, std::shared_ptr(new(...)) in favor of std::make_shared and other kinds of modernizations that can be done (semi-)automatically with clang-tidy(although some of those should be checked manually because sometimes it breaks the code. I think all of it can be done in this PR.

[ModMaker101]

Alright I'll work on it.

[void2012]

I enabled all modernize-* checks in .clang-tidy but today plan to add even more checks for aggressive standard conforming refactoring

[ModMaker101]

@void2012 You want me to work on renaming methods to match our current style?

[ModMaker101]

@void2012 We should probably merge this PR ASAP because in the future if I were to add more "modernization" it could break existing PRs/fixes which could lead to more friction. I have already implemented int -> size_t, more static_cast to replace C-style ones, replaced NULL with nullptr in most cases, and a few other things I was going to start on before recognizing that this could lead to friction. Would it be possible to review this PR and merge ASAP.

[ModMaker101]

@smartcmd if you could also review this that would be helpful.

[codeHusky]

Getting reports that this breaks pausing and tab menu. confirm i can't make a new world without the game crashing on latest release. prob gonna have to revert this, was not tested

[ModMaker101]

Must be an issue with nullptr somewhere

[ModMaker101]

I'll take a look