Fix FOV being applied twice from redundant fov->settings application.#811
Open
snowing64 wants to merge 2 commits intosmartcmd:mainfrom
Open
Fix FOV being applied twice from redundant fov->settings application.#811snowing64 wants to merge 2 commits intosmartcmd:mainfrom
snowing64 wants to merge 2 commits intosmartcmd:mainfrom
Conversation
Collaborator
|
Are you sure this is the right line to keep? It seems like the |
Author
|
I overlooked that, thanks. I redid the logic. It works on paper and with regular gameplay but I'm unsure if it works in a real split-screen environment. I wasn't able to test it with split-screen due to the logic for handling input being stubbed/nonexistent (didn't look into it comprehensively) on the Windows64 build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix FOV being applied twice from redundant fov->settings application. Bump the main field-of-view variables to array's that correspond with the max amount of local players (4).
Changes
Previous Behavior
When the FOV would be changed in the settings menu, both m_fov and options->fov would be set, and would be multiplied twice.

(on 110fov)
Root Cause
m_fov and options->fov were being written to. getFov() reads both, causing field of view to be multiplied.
New Behavior
Field of view applications works as intended.

(on 110fov)
Fix Implementation
Refactored field-of-view logic to correctly apply once in single-player and split-screen environments.
AI Use Disclosure
None.
Related Issues