Skip to content

Fix FOV being applied twice from redundant fov->settings application.#811

Open
snowing64 wants to merge 2 commits intosmartcmd:mainfrom
snowing64:main
Open

Fix FOV being applied twice from redundant fov->settings application.#811
snowing64 wants to merge 2 commits intosmartcmd:mainfrom
snowing64:main

Conversation

@snowing64
Copy link

@snowing64 snowing64 commented Mar 7, 2026

Description

Fix FOV being applied twice from redundant fov->settings application. Bump the main field-of-view variables to array's that correspond with the max amount of local players (4).

Changes

Previous Behavior

When the FOV would be changed in the settings menu, both m_fov and options->fov would be set, and would be multiplied twice.
(on 110fov)
image

Root Cause

m_fov and options->fov were being written to. getFov() reads both, causing field of view to be multiplied.

New Behavior

Field of view applications works as intended.
(on 110fov)
image

Fix Implementation

Refactored field-of-view logic to correctly apply once in single-player and split-screen environments.

AI Use Disclosure

None.

Related Issues

@codeHusky
Copy link
Collaborator

Are you sure this is the right line to keep? It seems like the iPad line is the one that would be safe to use considering split screen

@snowing64 snowing64 marked this pull request as draft March 7, 2026 10:55
@snowing64
Copy link
Author

I overlooked that, thanks. I redid the logic. It works on paper and with regular gameplay but I'm unsure if it works in a real split-screen environment. I wasn't able to test it with split-screen due to the logic for handling input being stubbed/nonexistent (didn't look into it comprehensively) on the Windows64 build.

@snowing64 snowing64 marked this pull request as ready for review March 7, 2026 20:02
@UnLimitedCaNNoNs UnLimitedCaNNoNs mentioned this pull request Mar 9, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] FOV 110 causes everything to FLIP when sprinting?

2 participants