Open
Conversation
Collaborator
|
Tests fine, but resets FOV to 30 if you have existing settings prior to this change. Pls fix and then should be good to merge |
Author
|
gotta fix some default setting after the merge resolution |
|
oh cool :0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the FOV slider to use the pre-existing FOV option as intended instead of hooking into gameRenderer. It also fixes some other minor issues with the existing FOV system and increases the range of FOV to 30-110.
Changes
Previous Behavior
The FOV slider was inaccurate because it modified a value gameRenderer expected to be hardcoded.
Additional Issues:
Root Cause
The FOV slider implemented by 4J in the debug menu (which was used as a reference for the slider in settings) modified the m_fov value in gameRenderer instead of modifying the existing option.
The FOV slider was also implemented as a 0-100 slider and the value was used to calculate an FOV, meaning that multiple stops of the slider corresponded with a single FOV value
The hand renderering code calls for the target FOV, meaning it is affected by FOV scaling.
New Behavior
The FOV slider now modifies the intended option value that gameRenderer expects it to. The FOV slider also now goes from 30-110 instead of 70-110.
The FOV slider is now 1:1, with each tick / stop corresponding to one discrete FOV value.
The hand viewmodel no longer scales with screen FOV.
Fix Implementation
Instead of using
gameRenderer->SetFovVal();, the slider now modifiesoptions->fov. This change is used in UIScene_SettingsGraphicsMenu.cpp, UIScene_DebugOverlay.cpp, and Consoles_App.cpp.Changed how
m_sliderFOVwas implemented, making it 0-80 to match the range of 30-110Added a hardcoded value into
gluPerspective();inGameRenderer::renderItemInHand();AI Use Disclosure
No AI was used to modify the code or author this pull request.
Related Issues