Conversation
|
Wdym by "somewhat" here
|
I changed the way I implemented a few things, and my formatting. The footnote for the video also describes a change from the original code, which was the height the player sits at in the boat. It was given an offset of -0.4 instead of -0.5. This change was to stop the player from colliding with the block underneath the boat. If you look at the video the player model is slightly darkened while on land, this is the reason that value was changed. When I say I changed the way I implemented things I mostly mean how I set the initial height for the boat. Instead of setting it in the boat constructor I set it in the _init() function. There are probably differences in formatting, I didn't just copy and paste the old code in since I wanted to redo it. But the outcome should be the same. |
2 participants
Description
This commit reimplements boat gravity. Which was removed in #615, readded by #651, then removed in #906 (??)
Changes
(Somewhat) reimplement changes made in my previous pull request, #651.
Previous Behavior
Boats may glitch into ground on ride.
Boats would create splash particles in any environment, depending on speed.
Rider floats above the boat
Root Cause
PR #651 was reverted.
New Behavior
Related Issues
Video of what gravity should now look like:
https://github.com/user-attachments/assets/10162dc1-9fcb-4bd4-b846-37ee2fbccb6d
*This video was filmed for #651, if it was filmed in this commit the player would sit 0.1 above where they were in the video. Everything else should be the same.
Hey, its 100% okay that #651 was reverted, but I didn't see any comment about it being reverted. I assume it was a mistake. If it wasn't a mistake, then just reject this pr.