Fix split-screen UI wrong positioning on window resize#989
Merged
codeHusky merged 2 commits intosmartcmd:mainfrom Mar 9, 2026
Merged
Fix split-screen UI wrong positioning on window resize#989codeHusky merged 2 commits intosmartcmd:mainfrom
codeHusky merged 2 commits intosmartcmd:mainfrom
Conversation
In vertical split at window heights below 1080, ComputeTileScale's min-scale clamp (>= 1.0) prevented the SWF from scaling down to fit, cropping the bottom and causing repositionHud to shift HUD elements downward. Chat and Tooltips additionally applied an offset from ComputeSplitContentOffset that only produced correct values at the 1920x1080 design resolution. Override the scale for vertical split so the SWF fits the full window height when it is shorter than the movie. Remove the broken content offset from Chat and Tooltips -- the tile crop already positions the content correctly.
Contributor
Author
|
@codeHusky i am also fixing gamma so wait a second |
The gamma shader sampled the full backbuffer texture (UV 0..1) into each player's viewport, stretching the entire screen into every split region. Extended the shader constant buffer with per-viewport UV offset and scale so each pass samples only its own portion of the backbuffer. ComputeViewportForPlayer was hardcoded to top/bottom for 2 players, ignoring the vertical split setting. Rewrote it to read each player's m_iScreenSection directly, which already accounts for the split orientation preference. Secondary players have no Graphics menu and cannot change gamma. CachePlayerGammas now reads the primary player's setting and applies it uniformly to all viewports.
Skullworks-Dev-Group
pushed a commit
to Skullworks-Dev-Group/MinecraftConsoles
that referenced
this pull request
Mar 9, 2026
piebotc
pushed a commit
to piebotc/LegacyEvolved
that referenced
this pull request
Mar 9, 2026
* Fix split-screen UI wrong positioning on window resize In vertical split at window heights below 1080, ComputeTileScale's min-scale clamp (>= 1.0) prevented the SWF from scaling down to fit, cropping the bottom and causing repositionHud to shift HUD elements downward. Chat and Tooltips additionally applied an offset from ComputeSplitContentOffset that only produced correct values at the 1920x1080 design resolution. Override the scale for vertical split so the SWF fits the full window height when it is shorter than the movie. Remove the broken content offset from Chat and Tooltips -- the tile crop already positions the content correctly. * Fix gamma post-process in split-screen The gamma shader sampled the full backbuffer texture (UV 0..1) into each player's viewport, stretching the entire screen into every split region. Extended the shader constant buffer with per-viewport UV offset and scale so each pass samples only its own portion of the backbuffer. ComputeViewportForPlayer was hardcoded to top/bottom for 2 players, ignoring the vertical split setting. Rewrote it to read each player's m_iScreenSection directly, which already accounts for the split orientation preference. Secondary players have no Graphics menu and cannot change gamma. CachePlayerGammas now reads the primary player's setting and applies it uniformly to all viewports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix split-screen HUD, Chat, and Tooltips rendering incorrectly when the Windows64 game window is below 1080p.
Changes
Previous Behavior
In 2-player vertical split (SPLIT_LEFT/RIGHT) at window heights below 1080, HUD elements (crosshair, hotbar, hearts, player name) shifted downward, and Chat/Tooltips drifted in the wrong direction. The issue worsened as the window got smaller — at 720p the HUD was noticeably off-center, and at very small windows elements could move entirely off-screen. Horizontal split and quadrant modes were not affected.
Root Cause
Two separate bugs, both originating from 4J's assumption that these platforms always run at 1080p:
1. ComputeTileScale clamp (HUD, Chat, Tooltips)
ComputeTileScalecomputesscale = max(scaleW, scaleH)then clamps it to>= 1.0to prevent the SWF from being rendered too small in quadrant mode. In vertical split,tileHeight = screenH. On consoles this equals the movie height (1080), soscaleH = 1.0and the clamp has no effect. On PC at sub-1080 heights (e.g. 900),scaleH = 900/1080 = 0.833gets clamped to 1.0, leaving the SWF at native 1920x1080 and cropping the bottom.repositionHudthen passesvisibleH = 900to ActionScript, which sees less than the full height and shifts elements downward to "center" them.2. ComputeSplitContentOffset (Chat, Tooltips)
Chat and Tooltips applied a position offset from
ComputeSplitContentOffsetto the tile origin. This function returned (0,0) at the design resolution (1920x1080) but computed incorrect offsets at any other size — Player 1 tooltips drifted left/right in vertical split and up/down in horizontal split. Player 2 was unaffected because the function only applied offsets to LEFT/TOP viewports.New Behavior
Split-screen HUD, Chat, and Tooltips render correctly at any window resolution on Windows64. At 1080p and above the rendering is unchanged. Below 1080p the overlays scale down to fit the full SWF height, keeping all elements in their designed positions.
Fix Implementation
HUD (
UIScene_HUD::render): AfterComputeTileScale, added a vertical-split override that allows the scale to go below 1.0 when the window height is less than the movie height. This scales the SWF down to fit the full height, sorepositionHudpassesvisibleH = movieHeightto ActionScript and no vertical repositioning occurs. The clamp is still active for horizontal split and quadrant mode where it is needed.Chat (
UIComponent_Chat::render) / Tooltips (UIComponent_Tooltips::render): Removed theComputeSplitContentOffsetcall entirely — the SWF content is already positioned correctly by the tile crop, so no additional offset is needed. Applied the same vertical-split scale-down fix as the HUD.Related Issues