Skip to content

chore(deployment): add canton selector#1895

Draft
rodrigombsoares wants to merge 1 commit intomainfrom
add-canton-selector
Draft

chore(deployment): add canton selector#1895
rodrigombsoares wants to merge 1 commit intomainfrom
add-canton-selector

Conversation

@rodrigombsoares
Copy link
Collaborator

DRAFT: EVM contracts doesn't seem to have canton selector yet. This is just for deployments devenv to work

@github-actions
Copy link

Metric add-canton-selector main
Coverage 70.1% 69.8%

AptosFamilySelector = "ac77ffec"
TVMFamilySelector = "647e2ba9"
SuiFamilySelector = "c4e05953"
EVMFamilySelector = "2812d52c"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I wish we could source these from somewhere else so that we wouldn't have to modify chainlink-ccip.

\cc @tt-cll maybe this can be part of the tooling adapter? adapter.ChainFamilySelector()

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm checking with @tt-cll, I think we can remove this method altogether on the 2.0 codepath

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1896

Trying to move the selector fetching to the chain adapters. If the only thing that needs it is the FQ dest chain config, then it should be able to be totally encapsulated in a chain package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants