Sending selector in RMN curse sequence#2063
Open
carte7000 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the RMN v2.1.0 curse/uncurse sequence inputs to carry an explicit chain selector, and wires that selector through the fastcurse adapter when invoking the on-chain sequences.
Changes:
- Added
ChainSelectortoSeqCurseInputandSeqUncurseInputfor RMN v2.1.0 sequences. - Updated the v2.1.0 fastcurse adapter to populate the new
ChainSelectorfield when executingRmnCurse/RmnUncurse.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
chains/evm/deployment/v2_1_0/sequences/rmn.go |
Extends RMN curse/uncurse sequence input structs with ChainSelector. |
chains/evm/deployment/v2_1_0/adapters/fastcurse.go |
Populates ChainSelector when calling RMN v2.1.0 curse/uncurse sequences. |
Comments suppressed due to low confidence (1)
chains/evm/deployment/v2_1_0/sequences/rmn.go:104
- SeqUncurseInput now includes ChainSelector, but RmnUncurse never reads/validates it (and always uses chain.Selector). Consider validating in.ChainSelector == chain.Selector and using the input selector when building the FunctionInput so the new parameter has an effect and prevents accidental cross-chain mismatches.
type SeqUncurseInput struct {
ChainSelector uint64
RMNAddress common.Address
Subjects [][16]byte
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
93
to
97
| type SeqCurseInput struct { | ||
| RMNAddress common.Address | ||
| Subjects [][16]byte | ||
| ChainSelector uint64 | ||
| RMNAddress common.Address | ||
| Subjects [][16]byte | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.