Update rc containers to allow main packages with multiple files.#937
Update rc containers to allow main packages with multiple files.#937
Conversation
There was a problem hiding this comment.
Pull request overview
Updates service Docker builds to build packages from directories (go build .) rather than a single main.go, aligning builds with standard Go multi-file main packages and supporting recent repository layout changes in the dev environment tooling.
Changes:
- Switch verifier/pricer/executor Docker builds from
go build main.gotogo build .. - Update indexer/aggregator Docker builds to build from
*/cmddirectories and adjust the release-stageCOPYpaths accordingly. - Fix
build/devenv/Justfileproduction build recipe to call service recipes from their current top-level locations (noservices/prefix).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| verifier/Dockerfile | Build the verifier from the package directory rather than a single file. |
| pricer/Dockerfile | Build the pricer from the package directory rather than a single file. |
| executor/Dockerfile | Build the executor from the package directory rather than a single file. |
| indexer/Dockerfile | Build from indexer/cmd and copy the resulting binary into the runtime image. |
| aggregator/Dockerfile | Build from aggregator/cmd and copy the resulting binary into the runtime image. |
| build/devenv/Justfile | Update build-docker-rc recipe to reference top-level service Justfiles. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
|
Code coverage report:
WARNING: go tool cover failed for coverage_target.out |
One of the rc container builds stopped working because the
main.gofile was split into two parts. This PR updates all containers to build the package rather than the a specific file.