Closed
Conversation
winder
changed the title
|
Code coverage report:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Indexer Scheduler
Tests were not properly stopping the service, this led to random panics causing
go testto fail even though the tests themselves pass. There were other lifecycle issues such as not waiting for the worker to exit whenStop()is called, and a hang ifStop()were to be called twice.Aggregator Batch Handler
This service returns immediately if the context is cancelled, but causes a race condition with the underlying goroutine in tests. The test ends but logs are still being written while the service shuts down.
Fix
This change adds more robust lifecycle management.
This PR replaces (and hopefully fixes) #958, which is failing due to the
build-claction attempting togo geta commit hash that doesn't exist.