Skip to content

mark errors as limit error #2048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ettec wants to merge 4 commits into
base: main
Choose a base branch
from
+9 −1
Open

mark errors as limit error #2048

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b478333
mark errors as limit error
ettec May 12, 2026
2212e64
additional constructor for limit breach errors
ettec May 12, 2026
3fcfb21
move to regular error
ettec May 12, 2026
196a665
remove marker interface
ettec May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion pkg/capabilities/errors/error.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
package errors

import "fmt"
import (
"fmt"
)

type Origin int

Expand Down Expand Up @@ -110,6 +112,12 @@ func NewPublicUserError(err error, errorCode ErrorCode) Error {
return NewError(err, VisibilityPublic, OriginUser, errorCode)
}

// NewLimitBreachedError creates a public user error that embeds the provided limit error, indicating that a CRE limit
// breach has occurred. The error message will include the provided errorMsg as a prefix for additional context.
func NewLimitBreachedError(errorMsg string, err error) Error {
return NewPublicUserError(fmt.Errorf("%s: %w", errorMsg, err), LimitExceeded)
Comment on lines +117 to +118
Copy link
Copy Markdown
Contributor

@jmank88 jmank88 May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align on Exceeded?

Suggested change
func NewLimitBreachedError(errorMsg string, err error) Error {
return NewPublicUserError(fmt.Errorf("%s: %w", errorMsg, err), LimitExceeded)
func NewLimitExceededError(errorMsg string, err error) Error {
return NewPublicUserError(fmt.Errorf("%s: %w", errorMsg, err), LimitExceeded)

}
Comment on lines +115 to +119
Comment on lines +115 to +119
Comment on lines +115 to +119

// NewPrivateSystemError indicates that the wrapped error is due to a system-level issue and may contain
// sensitive information that should only be visible to the node on which it occurred. The error code will still be
// visible to other nodes in the network.
Expand Down
Loading