Conversation
|
|
The latest Buf updates on your PR. Results from workflow Regenerate Protobuf Files / buf (pull_request).
|
karen-stepanyan
force-pushed
the
DF-23780
branch
from
8b5f958 to
478aa2a
Compare
product-security-plaid-production
bot
requested review from
ecPablo and
patrickhuie19
| string timestamp = 4; | ||
|
|
||
| string name = 5; | ||
| double value = 6; |
There was a problem hiding this comment.
thinking more about this, I don't know if this value will support histograms as they don't have a single value
There was a problem hiding this comment.
looks like official Prometheus protobufs use a more complex value: https://github.com/prometheus/client_model/blob/master/io/prometheus/client/metrics.proto#L75
There was a problem hiding this comment.
Discussed offline - we're going to drop Histogram support for now and focus on the immediate use case of Counters and Gauges.
To support histograms we need to figure out:
- How to define buckets
- How to handle when the buckets change
- How to handle initialisation
- Where to aggregate into the Histogram value
karen-stepanyan
force-pushed
the
DF-23780
branch
from
dc2d62c to
3580bea
Compare
| CreInfo creInfo = 1; | ||
| WorkflowKey workflow = 2; | ||
| string workflowExecutionID = 3; | ||
| string timestamp = 4; |
There was a problem hiding this comment.
for future reference - we're using a string to match the Log proto: https://github.com/smartcontractkit/chainlink-protos/blob/main/workflows/workflows/v2/workflow_user_log.proto#L14
2 participants
https://smartcontract-it.atlassian.net/browse/DF-23779