Skip to content

fix(framework): return aptos container instance#2548

Merged
gustavogama-cll merged 1 commit intomainfrom
ggama/fix/return-aptos-container
May 4, 2026
Merged

fix(framework): return aptos container instance#2548
gustavogama-cll merged 1 commit intomainfrom
ggama/fix/return-aptos-container

Conversation

@gustavogama-cll
Copy link
Copy Markdown
Contributor

@gustavogama-cll gustavogama-cll commented Apr 28, 2026

This enables client code to properly cleanup the container.

@gustavogama-cll gustavogama-cll marked this pull request as ready for review April 29, 2026 02:23
@gustavogama-cll gustavogama-cll requested a review from a team as a code owner April 29, 2026 02:23
Copilot AI review requested due to automatic review settings April 29, 2026 02:23
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the Aptos blockchain component to return the underlying Testcontainers container instance in the blockchain.Output, aligning Aptos behavior with other blockchain implementations in the framework.

Changes:

  • Populate Output.Container in newAptos(...) so callers can access/manage the running container.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gustavogama-cll gustavogama-cll merged commit 9c91296 into main May 4, 2026
77 of 81 checks passed
@gustavogama-cll gustavogama-cll deleted the ggama/fix/return-aptos-container branch May 4, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants