Conversation
|
👋 huangzhen1997, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
There was a problem hiding this comment.
Pull request overview
Updates the default destination-chain FeeQuoter configuration used by the TON lane adapter in the CCIP 1.6.0 deployment sequences.
Changes:
- Tightens TON destination message limits (e.g.,
MaxDataBytes,MaxNumberOfTokensPerMsg). - Adjusts TON gas accounting parameters (
DestGasOverhead, per-payload-byte gas). - Adds/sets additional v1 params (e.g.,
GasPriceStalenessThreshold,EnforceOutOfOrder).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| DestDataAvailabilityOverheadGas: 0, | ||
| DestGasPerDataAvailabilityByte: 0, | ||
| DestDataAvailabilityMultiplierBps: 0, | ||
| GasMultiplierWeiPerEth: 1e18, |
There was a problem hiding this comment.
GasMultiplierWeiPerEth: 1e18 relies on scientific notation, which is easy to misread as a float literal. Using an explicit integer literal (e.g., with _ separators) would avoid any ambiguity and match the style of the surrounding constants.
| GasMultiplierWeiPerEth: 1e18, | |
| GasMultiplierWeiPerEth: 1_000_000_000_000_000_000, |
| DestDataAvailabilityMultiplierBps: 0, | ||
| GasMultiplierWeiPerEth: 1e18, | ||
| GasPriceStalenessThreshold: 90000, | ||
| EnforceOutOfOrder: true, |
There was a problem hiding this comment.
EnforceOutOfOrder is set on lanes.FeeQuoterV1Params, but the TON on-chain feequoter.DestChainConfig type does not have an EnforceOutOfOrder field and intoUpdateFeeQuoterDestChainConfigs does not propagate it. This makes the setting a no-op and potentially misleading; either remove it from the TON config here or add an explicit comment explaining it’s intentionally ignored/always true for TON.
| EnforceOutOfOrder: true, | |
| EnforceOutOfOrder: true, // NOTE: TON's on-chain feequoter.DestChainConfig has no EnforceOutOfOrder field; this value is not propagated and TON effectively always enforces out-of-order. |
| return lanes.FeeQuoterDestChainConfig{ | ||
| IsEnabled: true, | ||
| MaxDataBytes: 30_000, | ||
| MaxDataBytes: 2000, |
There was a problem hiding this comment.
For consistency/readability with the other numeric literals in this config (which use _ separators), consider writing MaxDataBytes as 2_000.
| MaxDataBytes: 2000, | |
| MaxDataBytes: 2_000, |
|
I noticed the devenv tests were failing for TON because the code was still commented out. smartcontractkit/chainlink-ccip#1899 fixes it |
No description provided.