Skip to content

chore: remove unused signatures package#21743

Draft
harry-anderson wants to merge 2 commits intodevelopfrom
chore/remove-unused-signatures-package
Draft

chore: remove unused signatures package#21743
harry-anderson wants to merge 2 commits intodevelopfrom
chore/remove-unused-signatures-package

Conversation

@harry-anderson
Copy link
Contributor

Summary

Removes the core/services/signatures/ directory tree which contains unused code:

  • ethschnorr - Schnorr signature implementation
  • ethdss - Distributed Schnorr Signature protocol
  • cryptotest - Test utilities for the above

These packages are not imported by any production code. Both ethschnorr and ethdss carry explicit XXX: Do not use in production until this code has been audited warnings and have never been integrated into any active code path.

Test plan

  • CI passes (no compilation errors from removed imports)
  • Confirmed via grep that no package outside core/services/signatures/ imports any of these packages

@github-actions
Copy link
Contributor

github-actions bot commented Mar 26, 2026

✅ No conflicts with other open PRs targeting develop

@github-actions
Copy link
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@trunk-io
Copy link

trunk-io bot commented Mar 26, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
Test_CRE_V2_EVM_Read_HeavyCalls/[v2]_EVM_Read_(heavy-calls)_-_workflow-gateway-capabilities/Read_EVMReadCallContract/on_chain_2337 The test failed during the process of deploying and configuring an EVM read workflow, but the specific cause of failure is not indicated in the pro... Logs ↗︎
Test_CRE_V2_EVM_Read_HeavyCalls The test failed during an Ethereum transaction that was waiting to be mined. Logs ↗︎
Test_CRE_V2_EVM_Read_HeavyCalls/[v2]_EVM_Read_(heavy-calls)_-_workflow-gateway-capabilities/Read_EVMReadCallContract The test failed during an Ethereum contract read operation, likely due to an issue with the contract or transaction processing. Logs ↗︎
Test_CRE_V2_EVM_Read_HeavyCalls/[v2]_EVM_Read_(heavy-calls)_-_workflow-gateway-capabilities The test failed without providing specific error details. Logs ↗︎

View Full Report ↗︎Docs

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant