Skip to content

Vault payload size optimizations#22388

Draft
russell-stern wants to merge 4 commits into
developfrom
optimize_vault_response_sizes
Draft

Vault payload size optimizations#22388
russell-stern wants to merge 4 commits into
developfrom
optimize_vault_response_sizes

Conversation

@russell-stern
Copy link
Copy Markdown
Contributor

Summary

  • Added base64 encoding for vault don secrets and shares, controlled through a flag. When enabled secrets and shares will be converted from hex to base64 encoding to decrease payload sizes

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 11, 2026

CORA - Pending Reviewers

Codeowners Entry Overall Num Files Owners
* 5 @smartcontractkit/foundations, @smartcontractkit/core
/core/capabilities/ 5 @smartcontractkit/keystone, @smartcontractkit/capabilities-team
/core/services/ocr*/ 4 @smartcontractkit/foundations, @smartcontractkit/core
/.github/** 1 @smartcontractkit/devex-cicd, @smartcontractkit/devex-tooling, @smartcontractkit/core
go.mod 6 @smartcontractkit/core, @smartcontractkit/foundations
go.sum 6 @smartcontractkit/core, @smartcontractkit/foundations
integration-tests/go.mod 1 @smartcontractkit/core, @smartcontractkit/devex-tooling, @smartcontractkit/foundations
integration-tests/go.sum 1 @smartcontractkit/core, @smartcontractkit/devex-tooling, @smartcontractkit/foundations

Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown

For more details, see the full review summary.

@github-actions
Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 11, 2026

✅ No conflicts with other open PRs targeting develop

@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented May 11, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
TestConfigureForwarder Logs ↗︎
TestConfigureForwarder/set_config_with_mcms Logs ↗︎
TestConfigureForwarder/set_config_with_mcms The test failed without a specific error message, indicating an unspecified failure during the configuration process. Logs ↗︎
TestScripts/nodes/solana/list/list The test failed because the expected output did not match the actual output, indicating a discrepancy in the script's output. Logs ↗︎

... and 7 more

View Full Report ↗︎Docs

@cl-sonarqube-production
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant