Skip to content

fix: remove delve from public images #22389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
erikburt wants to merge 2 commits into
base: develop
Choose a base branch
from
+17 −6
Open

fix: remove delve from public images #22389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b76a72
fix: remove delve from official images
erikburt May 11, 2026
5b69097
empty commit
erikburt May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/build-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ jobs:
aws-region-gati: us-west-2
dockerfile: core/chainlink.Dockerfile
docker-build-context: .
docker-target: final
docker-build-args: |
CHAINLINK_USER=chainlink
COMMIT_SHA=${{ github.sha }}
Expand Down Expand Up @@ -142,6 +143,7 @@ jobs:
aws-region-gati: us-west-2
dockerfile: core/chainlink.Dockerfile
docker-build-context: .
docker-target: final
docker-build-args: |
CHAINLINK_USER=chainlink
COMMIT_SHA=${{ github.sha }}
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/docker-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@
aws-region-gati: us-west-2
dockerfile: core/chainlink.Dockerfile
docker-build-context: .
docker-target: debug
docker-build-args: |
CHAINLINK_USER=chainlink
COMMIT_SHA=${{ needs.init.outputs.checked-out-sha }}
Expand Down Expand Up @@ -127,6 +128,7 @@
aws-region-gati: us-west-2
dockerfile: plugins/chainlink.Dockerfile
docker-build-context: .
docker-target: debug
docker-build-args: |
CHAINLINK_USER=chainlink
COMMIT_SHA=${{ needs.init.outputs.checked-out-sha }}
Expand Down Expand Up @@ -161,6 +163,7 @@
aws-region-gati: us-west-2
dockerfile: plugins/chainlink.Dockerfile
docker-build-context: .
docker-target: debug
docker-build-args: |
CHAINLINK_USER=chainlink
COMMIT_SHA=${{ needs.init.outputs.checked-out-sha }}
Expand Down Expand Up @@ -196,6 +199,7 @@
aws-region-gati: us-west-2
dockerfile: core/chainlink.Dockerfile
docker-build-context: .
docker-target: debug
docker-build-args: |
CHAINLINK_USER=chainlink
COMMIT_SHA=${{ needs.init.outputs.checked-out-sha }}
Expand Down Expand Up @@ -231,6 +235,7 @@
aws-region-gati: us-west-2
dockerfile: plugins/chainlink.Dockerfile
docker-build-context: .
docker-target: debug
docker-build-args: |
CHAINLINK_USER=chainlink
COMMIT_SHA=${{ needs.init.outputs.checked-out-sha }}
Expand Down Expand Up @@ -268,7 +273,7 @@
secrets: inherit

deploy-nightly-core:
if: false

Check failure on line 276 in .github/workflows/docker-build.yml

View workflow job for this annotation

GitHub Actions / Validate Github Action Workflows 

[actionlint] reported by reviewdog 🐶
constant expression "false" in condition. remove the if: section [if-cond]

Raw Output:
e:.github/workflows/docker-build.yml:276:9: constant expression "false" in condition. remove the if: section [if-cond]
# temporarily disabled
# if: ${{ github.event_name == 'schedule' }}
needs: [ docker-core ]
Expand Down
8 changes: 5 additions & 3 deletions core/chainlink.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ RUN --mount=type=cache,target=/root/.cache/go-build,id=go-build-chainlink \
##
# Final Image
##
FROM ubuntu:24.04
FROM ubuntu:24.04 AS final

ARG CHAINLINK_USER=root
ENV DEBIAN_FRONTEND=noninteractive
Expand Down Expand Up @@ -133,8 +133,6 @@ COPY --from=build-local-plugins /gobins/ /usr/local/bin/
COPY --from=build-chainlink /gobins/ /usr/local/bin/
# Copy shared libraries from the remote plugins build stage.
COPY --from=build-remote-plugins /tmp/lib /usr/lib/
COPY --from=build-delve /go/bin/dlv /usr/local/bin/


WORKDIR /home/${CHAINLINK_USER}

Expand All @@ -151,3 +149,7 @@ EXPOSE 6688
ENTRYPOINT ["chainlink"]
HEALTHCHECK CMD curl -f http://localhost:6688/health || exit 1
CMD ["local", "node"]

FROM final AS debug

COPY --from=build-delve /go/bin/dlv /usr/local/bin/
Comment thread
erikburt marked this conversation as resolved.
8 changes: 5 additions & 3 deletions plugins/chainlink.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ RUN --mount=type=cache,target=/root/.cache/go-build,id=go-build-chainlink \
##
# Final Image
##
FROM ubuntu:24.04
FROM ubuntu:24.04 AS final

ARG CHAINLINK_USER=root
ENV DEBIAN_FRONTEND=noninteractive
Expand All @@ -110,8 +110,6 @@ RUN curl https://www.postgresql.org/media/keys/ACCC4CF8.asc | apt-key add - \
RUN if [ ${CHAINLINK_USER} != root ]; then useradd --uid 14933 --create-home ${CHAINLINK_USER}; fi
USER ${CHAINLINK_USER}

COPY --from=build-delve /go/bin/dlv /usr/local/bin/dlv

# Expose image metadata to the running node.
ARG CL_AUTO_DOCKER_TAG=unset
ENV CL_DOCKER_TAG=${CL_AUTO_DOCKER_TAG}
Expand Down Expand Up @@ -146,3 +144,7 @@ EXPOSE 6688
ENTRYPOINT ["chainlink"]
HEALTHCHECK CMD curl -f http://localhost:6688/health || exit 1
CMD ["local", "node"]

FROM final AS debug

COPY --from=build-delve /go/bin/dlv /usr/local/bin/dlv
Comment thread
erikburt marked this conversation as resolved.
Loading