Ccip-11386 permablessed commit stores in rmn ccip view#22390
Conversation
AnieeG
requested review from
asoliman92,
b-gopalswami,
carte7000,
chris-de-leon-cll,
ogtownsend,
tt-cll and
winder
|
👋 AnieeG, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
|
✅ No conflicts with other open PRs targeting |
There was a problem hiding this comment.
Pull request overview
Risk Rating: LOW — adds an additional view field populated via an extra contract call, plus a unit/integration test update.
This PR extends the CCIP deployment “view” for the v1.5 RMN contract to include the list of perma-blessed commit stores, so downstream tooling can surface this state in JSON views.
Changes:
- Add
permaBlessedCommitStorestoRMNViewand populate it viaGetPermaBlessedCommitStores. - Extend
TestGenerateRMNViewto set and assert the perma-blessed commit store list.
Scrupulous human review recommended (targeted areas):
deployment/ccip/view/v1_5/rmn.go:31-34— error handling for the added contract call should be consistent and include context.deployment/ccip/view/v1_5/rmn_test.go:55-58— correctness of the contract method used to mutate perma-blessed commit stores in the simulated environment (ensuring it matches intended on-chain behavior and permissions).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| deployment/ccip/view/v1_5/rmn.go | Adds a new JSON field to RMN view and fetches it from the contract. |
| deployment/ccip/view/v1_5/rmn_test.go | Updates the RMN view test to set and verify perma-blessed commit stores. |
| } | ||
| cs, err := r.GetPermaBlessedCommitStores(nil) | ||
| if err != nil { | ||
| return RMNView{}, err |
| if err != nil { | ||
| return RMNView{}, fmt.Errorf("failed to get config details for RMN: %w", err) | ||
| } | ||
| cs, err := r.GetPermaBlessedCommitStores(nil) |
| BlessWeightThreshold: uint16(2), | ||
| CurseWeightThreshold: uint16(1), | ||
| } | ||
| permablessedStore := utils.RandomAddress() |
|
crispymangoes
left a comment
crispymangoes
left a comment
There was a problem hiding this comment.
Can we test running generate state command from cld repo? Other than that looks good.
Requires
Supports