rm unused changesets from deployment/keystone#22425
Merged
Merged
Conversation
Contributor
|
✅ No conflicts with other open PRs targeting |
|
product-security-plaid-production
Bot
requested review from
gustavogama-cll and
jmank88
jmank88
approved these changes
May 12, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Risk Rating: LOW — This PR only removes unused/dead Solana Keystone deployment changeset code (no functional additions or behavioral changes).
Changes:
- Removed the Solana “forwarder” changeset implementation from
deployment/keystone/changeset/solana/(deploy/configure/ownership). - Removed the associated Solana sequence + operation helpers used by that changeset.
- Removed the corresponding Solana forwarder tests and build-params helper that were scoped to the deleted changeset.
Areas for scrupulous human review:
- Confirm there are no external/internal consumers (scripts, docs, downstream repos) that still expect the deleted Keystone Solana changeset package paths or identifiers (the codebase search in this repo shows no remaining references, but downstream usage can’t be verified here).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| deployment/keystone/changeset/solana/sequence/seq_forwarder.go | Removed unused Solana forwarder deployment sequence. |
| deployment/keystone/changeset/solana/sequence/operation/operation.go | Removed unused Solana forwarder operations (init/configure/authority). |
| deployment/keystone/changeset/solana/deploy_forwarder.go | Removed unused Keystone Solana forwarder changeset entrypoints. |
| deployment/keystone/changeset/solana/deploy_forwarder_test.go | Removed tests tied to the deleted Keystone Solana forwarder changeset. |
| deployment/keystone/changeset/solana/cs_ownership.go | Removed unused ownership-transfer changeset wrapper for Solana forwarder. |
| deployment/keystone/changeset/solana/cs_build_solana.go | Removed unused Solana build params helper for the deleted changeset. |
ilija42
approved these changes
May 12, 2026
gustavogama-cll
approved these changes
May 12, 2026
bolekk
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires
Supports