Skip to content

fix: remove and swap usage of run changeset to cld-changeset repo#22432

Merged
ajaskolski merged 2 commits into
developfrom
fix-swap-run-changeset-to-cld-changeset-repo
May 14, 2026
Merged

fix: remove and swap usage of run changeset to cld-changeset repo#22432
ajaskolski merged 2 commits into
developfrom
fix-swap-run-changeset-to-cld-changeset-repo

Conversation

@ajaskolski
Copy link
Copy Markdown
Contributor

@ajaskolski ajaskolski commented May 13, 2026

Swap usage of run changeset to import cld-changeset.
Updated, merged usage in cld -> https://github.com/smartcontractkit/chainlink-deployments/pull/14076
https://smartcontract-it.atlassian.net/browse/CLD-2108

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 13, 2026

CORA - Pending Reviewers

All codeowners have approved! ✅

Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown

For more details, see the full review summary.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 13, 2026

✅ No conflicts with other open PRs targeting develop

@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented May 13, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@ajaskolski ajaskolski force-pushed the fix-swap-run-changeset-to-cld-changeset-repo branch 6 times, most recently from a39a56a to dcaad84 Compare May 14, 2026 10:32
@ajaskolski ajaskolski force-pushed the fix-swap-run-changeset-to-cld-changeset-repo branch from dcaad84 to ca03b7f Compare May 14, 2026 10:40
@ajaskolski ajaskolski force-pushed the fix-swap-run-changeset-to-cld-changeset-repo branch from ca03b7f to 63755ee Compare May 14, 2026 10:47
@cl-sonarqube-production
Copy link
Copy Markdown

@ajaskolski ajaskolski marked this pull request as ready for review May 14, 2026 11:21
Copilot AI review requested due to automatic review settings May 14, 2026 11:21
@ajaskolski ajaskolski requested review from a team as code owners May 14, 2026 11:21
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Risk Rating: HIGH

Migrates remaining RunChangeset call sites from the local deployment helper to the cld-changesets module, while updating related MCMS timelock config usage in CCIP add-chain flows.

Changes:

  • Replaced local RunChangeset imports/calls with cld-changesets/pkg/common/changeset.
  • Removed the local deployment/common/changeset/run_changeset.go helper.
  • Updated system-test module dependencies and CCIP tests to use V2 MCMS timelock config helpers.

Scrupulous human review areas:

  • Removal of exported RunChangeset/WrappedChangeSet API from deployment/common/changeset.
  • CCIP AddCandidatesForNewChainConfig type change and conversion into framework MCMS config.
  • Changeset execution behavior parity between the old local helper and the external cld-changesets helper.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
deployment/common/changeset/run_changeset.go Removes local exported changeset runner helper.
deployment/ccip/changeset/v1_6/cs_add_new_chain_e2e.go Uses external changeset runner and V2 MCMS config type.
deployment/ccip/changeset/v1_6/cs_add_new_chain_e2e_test.go Updates tests to use V2 timelock config helper.
deployment/data-feeds/changeset/new_feed_with_proxy.go Uses external changeset runner while retaining local ownable contract loader.
integration-tests/smoke/ccip/ccip_add_chain_e2e_test.go Updates integration setup to use V2 timelock config helper.
system-tests/lib/cre/contracts/contracts.go Uses external changeset runner for data feeds cache operations.
system-tests/lib/go.mod Promotes cld-changesets to a direct dependency.
system-tests/tests/go.mod Promotes cld-changesets to a direct dependency.
system-tests/tests/smoke/cre/por_helpers.go Uses external changeset runner for Tron PoR setup.
system-tests/tests/smoke/cre/sharding_test.go Uses external changeset runner for shard count updates.
Comments suppressed due to low confidence (1)

deployment/common/changeset/run_changeset.go:1

  • Removing these exported symbols from the deployment module is a breaking API change for any downstream code that still imports deployment/common/changeset.RunChangeset or WrappedChangeSet; the internal callers were migrated, but external callers will now fail to compile. Consider keeping a deprecated forwarding wrapper to cld-changesets/pkg/common/changeset.RunChangeset for a transition period.

Comment thread system-tests/tests/go.mod
Comment thread system-tests/lib/go.mod
@ajaskolski ajaskolski added this pull request to the merge queue May 14, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 14, 2026
@ajaskolski ajaskolski added this pull request to the merge queue May 14, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 14, 2026
@ajaskolski ajaskolski added this pull request to the merge queue May 14, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 14, 2026
@ajaskolski ajaskolski added this pull request to the merge queue May 14, 2026
@mchain0 mchain0 removed this pull request from the merge queue due to a manual request May 14, 2026
@ajaskolski ajaskolski added this pull request to the merge queue May 14, 2026
Merged via the queue into develop with commit 973a235 May 14, 2026
227 of 228 checks passed
@ajaskolski ajaskolski deleted the fix-swap-run-changeset-to-cld-changeset-repo branch May 14, 2026 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants