Conversation
🦋 Changeset detectedLatest commit: 73209ca The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| if ( | ||
| !( | ||
| value && | ||
| value.startsWith('-----BEGIN PRIVATE KEY-----\n') && |
There was a problem hiding this comment.
This is a real line break rather than backslash n, no?
There was a problem hiding this comment.
This is correct, when loading env var you need to set it as
PRIVATE_KEY="-----BEGIN PRIVATE KEY-----\n......."
instead of
PRIVATE_KEY="-----BEGIN PRIVATE KEY-----
......."
There was a problem hiding this comment.
Did you test it manually end-to-end? It doesn't look like that's true. In the integration test you also put a real line break.
There was a problem hiding this comment.
Yes, I assume you mean
process.env.PUBLIC_CERT =
'-----BEGIN CERTIFICATE-----\nfake-public-cert\n-----END CERTIFICATE-----'
Here the line break happens outside of the value, you just can't have it in-side the single quote
| if ( | ||
| !( | ||
| value && | ||
| value.startsWith('-----BEGIN PRIVATE KEY-----\n') && |
There was a problem hiding this comment.
Did you test it manually end-to-end? It doesn't look like that's true. In the integration test you also put a real line break.
Closes #OPDATA-6773
Description
Implement market status endpoint for six
Quality Assurance
infra-k8sconfiguration file.adapter-secretsconfiguration file.test-payload.jsonfile with relevant requests.feature/x,chore/x,release/x,hotfix/x,fix/x) or is created from Jira.