Skip to content

Six adapter#4949

Open
mxiao-cll wants to merge 4 commits into
mainfrom
six
Open

Six adapter#4949
mxiao-cll wants to merge 4 commits into
mainfrom
six

Conversation

@mxiao-cll
Copy link
Copy Markdown
Contributor

Closes #OPDATA-6773

Description

Implement market status endpoint for six

Quality Assurance

  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant infra-k8s configuration file.
  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant adapter-secrets configuration file.
  • If a new adapter was made, or a new endpoint was added, update the test-payload.json file with relevant requests.
  • The branch naming follows git flow (feature/x, chore/x, release/x, hotfix/x, fix/x) or is created from Jira.
  • This is related to a maximum of one Jira story or GitHub issue.
  • Types are safe (avoid TypeScript/TSLint features like any and disable, instead use more specific types).
  • All code changes have 100% unit and integration test coverage. If testing is not applicable or too difficult to justify doing, the reasoning should be documented explicitly in the PR.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 11, 2026

🦋 Changeset detected

Latest commit: 73209ca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@chainlink/six-adapter Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mxiao-cll mxiao-cll requested a review from a team May 11, 2026 19:00
Comment thread packages/sources/six/src/config/index.ts Outdated
Comment thread packages/sources/six/src/transport/market-status.ts
Comment thread packages/sources/six/src/config/index.ts Outdated
Comment thread packages/sources/six/src/transport/market-status.ts Outdated
@mxiao-cll mxiao-cll requested review from a team and dskloetc May 12, 2026 14:35
Comment thread packages/sources/six/src/transport/market-status.ts
Comment thread packages/sources/six/src/config/index.ts
if (
!(
value &&
value.startsWith('-----BEGIN PRIVATE KEY-----\n') &&
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a real line break rather than backslash n, no?

Copy link
Copy Markdown
Contributor Author

@mxiao-cll mxiao-cll May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct, when loading env var you need to set it as

PRIVATE_KEY="-----BEGIN PRIVATE KEY-----\n......."

instead of

PRIVATE_KEY="-----BEGIN PRIVATE KEY-----
......."

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test it manually end-to-end? It doesn't look like that's true. In the integration test you also put a real line break.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I assume you mean

    process.env.PUBLIC_CERT =
      '-----BEGIN CERTIFICATE-----\nfake-public-cert\n-----END CERTIFICATE-----'

Here the line break happens outside of the value, you just can't have it in-side the single quote

if (
!(
value &&
value.startsWith('-----BEGIN PRIVATE KEY-----\n') &&
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test it manually end-to-end? It doesn't look like that's true. In the integration test you also put a real line break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants