Conversation
|
👋 cfal, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
JohnChangUK
previously approved these changes
Mar 28, 2026
Set.GoType() was returning "SET" instead of "types.SET", and the
DALF parser never instantiated model.Set{} for Set type constructors
from imported stdlib packages. This caused generated Go code to
reference an undefined `Set` type instead of `types.SET`.
Also adds Set and RelTime handling to the PackageImportId branch
of handleConType, which previously had no stdlib type special cases.
Collaborator
|
changes are already in |
auto-merge was automatically disabled
April 13, 2026 16:52
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set.GoType() was returning "SET" instead of "types.SET", and the DALF parser never instantiated model.Set{} for Set type constructors from imported stdlib packages. This caused generated Go code to reference an undefined
Settype instead oftypes.SET.Also adds Set and RelTime handling to the PackageImportId branch of handleConType, which previously had no stdlib type special cases.