Add event streaming signing support#1051
Closed
sugmanue wants to merge 1 commit intosmithy-lang:mainfrom
Closed
Conversation
mtdowling
requested changes
Mar 5, 2026
| final Map<ShapeId, AuthScheme<?, ?>> supportedAuthSchemes; | ||
| final IdentityResolvers identityResolvers; | ||
|
|
||
| final ProtocolEventStreamWriter<SerializableStruct, SerializableStruct, Frame<?>> writer; |
Member
There was a problem hiding this comment.
writer feels too non-descript. Maybe call it eventStreamWriter
Contributor
Author
There was a problem hiding this comment.
Yes, I will change it.
| ApiOperation<I, O> operation, | ||
| RequestOverrideConfig overrideConfig | ||
| ) { | ||
| ProtocolEventStreamWriter<SerializableStruct, SerializableStruct, Frame<?>> writer = null; |
core/src/main/java/software/amazon/smithy/java/core/serde/event/ProtocolEventStreamWriter.java
Show resolved
Hide resolved
|
|
||
| @Override | ||
| public EventEncoderFactory<AwsEventFrame> withFrameProcessor(FrameProcessor<AwsEventFrame> frameProcessor) { | ||
| return new AwsEventEncoderFactory(initialEventType, |
Member
There was a problem hiding this comment.
This throws away the current frame processer rather than composing them. Is that intentional?
Contributor
Author
There was a problem hiding this comment.
Yes, it's intentional. Composing can work too, I just don't feel like the extra layer will give any value for this use.
Member
There was a problem hiding this comment.
Seems like we need another version of this that composes, no? Otherwise you wouldn't be able to decorate frame processors (e.g., gzip -> sign).
...src/main/java/software/amazon/smithy/java/aws/client/auth/scheme/sigv4/SigV4EventSigner.java
Show resolved
Hide resolved
Contributor
Author
|
Closing in favor of #1054 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds support for signing event streams using SigV4.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.