Skip to content

Add singletons for AwsCredentialsResolver impls #1059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kstich merged 2 commits into from
Mar 11, 2026
Merged

Add singletons for AwsCredentialsResolver impls #1059

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91bb0bf
Add singletons for AwsCredentialsResolver impls
kstich Mar 10, 2026
f8cd5ea
Merge branch 'main' into dev/kstich/AwsCredentialsResolver_instances
kstich Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...ware/amazon/smithy/java/aws/client/core/identity/EnvironmentVariableIdentityResolver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
* </dl>
*/
public final class EnvironmentVariableIdentityResolver implements AwsCredentialsResolver {
public static final EnvironmentVariableIdentityResolver INSTANCE = new EnvironmentVariableIdentityResolver();

private static final String ACCESS_KEY_PROPERTY = "AWS_ACCESS_KEY_ID";
private static final String SECRET_KEY_PROPERTY = "AWS_SECRET_ACCESS_KEY";
private static final String SESSION_TOKEN_PROPERTY = "AWS_SESSION_TOKEN";
Expand Down
2 changes: 2 additions & 0 deletions ...oftware/amazon/smithy/java/aws/client/core/identity/SystemPropertiesIdentityResolver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@
* @see <a href="https://docs.oracle.com/javase/tutorial/essential/environment/sysprop.html">Java System Properties</a>
*/
public final class SystemPropertiesIdentityResolver implements AwsCredentialsResolver {
public static final SystemPropertiesIdentityResolver INSTANCE = new SystemPropertiesIdentityResolver();

private static final String ACCESS_KEY_PROPERTY = "aws.accessKeyId";
private static final String SECRET_KEY_PROPERTY = "aws.secretAccessKey";
private static final String SESSION_TOKEN_PROPERTY = "aws.sessionToken";
Expand Down
2 changes: 1 addition & 1 deletion .../amazon/smithy/java/aws/client/core/identity/EnvironmentVariableIdentityResolverTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public class EnvironmentVariableIdentityResolverTest {

@Test
void resolverReturnsExpectedIdentity() {
var resolver = new EnvironmentVariableIdentityResolver();
var resolver = EnvironmentVariableIdentityResolver.INSTANCE;
var value = resolver.resolveIdentity(Context.empty());
var expected = AwsCredentialsIdentity.create(
"env_access_key",
Expand Down
2 changes: 1 addition & 1 deletion ...are/amazon/smithy/java/aws/client/core/identity/SystemPropertiesIdentityResolverTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
public class SystemPropertiesIdentityResolverTest {
@Test
void resolverReturnsExpectedIdentity() {
var resolver = new SystemPropertiesIdentityResolver();
var resolver = SystemPropertiesIdentityResolver.INSTANCE;
var value = resolver.resolveIdentity(Context.empty());
var expected = AwsCredentialsIdentity.create(
"property_access_key",
Expand Down
2 changes: 1 addition & 1 deletion cli/src/main/java/software/amazon/smithy/java/cli/SmithyCall.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ private void configureAuth(DynamicClient.Builder builder, ShapeId serviceInput,
.profileName(auth.awsProfile);
builder.addIdentityResolver(new SdkCredentialsResolver(profileBuilder.build()));
} else {
builder.addIdentityResolver(new EnvironmentVariableIdentityResolver());
builder.addIdentityResolver(EnvironmentVariableIdentityResolver.INSTANCE);
}
break;
case "none":
Expand Down
Loading