Open
Conversation
I think you need to replace spaces with "_". Otherwise Portshaker gets confused when you use Git branches in some sources, and tries to call the `merge_to` sub command like: ``` merge_to -m source branch -t /usr/local/poudriere/ports/target ```
Author
|
This patch/PR will fix the problem where Portshaker would randomly spit out the following when you are using a Git branch name in your |
Owner
|
Hum, the project got its root before FreeBSD switched to git, I am not sure if spaces in branch names where a possible thing with svn, but the presence of quotes at this location make me think that the code should handle it (and quotes are probably missing somewhere else). Either we should:
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think you need to replace spaces with "_". Otherwise Portshaker gets confused when you use Git branches in some sources, and tries to call the
merge_tosub command like: