fix: isolate test environment from external variables

[robertolopezlopez]

Description

This PR adds an extendable mechanism to ignore environment variables in unit tests.

Checklist

• Tests added and all succeed (make test)
• Regenerated mocks, etc. (make generate)
• Linted (make lint)
• Test your changes work for the CLI
  1. Clone / pull the latest CLI main.
  2. Run go get github.com/snyk/go-application-framework@YOUR_LATEST_GAF_COMMIT in the cliv2 directory.
     • Tip: for local testing, you can uncomment the line near the bottom of the CLI's go.mod to point to your local GAF code.
  3. Run go mod tidy in the cliv2 directory.
  4. Run the CLI tests and do any required manual testing.
  5. Open a PR in the CLI repo now with the go.mod and go.sum changes.
  • Once this PR is merged, repeat these steps, but pointing to the latest GAF commit on main and update your CLI PR.

[snyk-io]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues
✅	Licenses	0	0	0	0	0 issues
✅	Code Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[snyk-io]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues
✅	Licenses	0	0	0	0	0 issues
✅	Code Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[danskmt]

Should we ALWAYS consider ignoring the KnownLeakEnvironmentKeys values?
If so, we should concat always.
In the current way, if parameters for keys are passed, the KnownLeakEnvironmentKeys are not being considered

[robertolopezlopez]

this behavior has been documented in my last commit

[snyk-pr-review-bot]

PR Reviewer Guide 🔍

🧪 PR contains tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Partial Isolation 🟡 [minor] The function IsolateEnvironmentForTest uses t.Setenv(k, "") to clear variables. While this overwrites the value, it still leaves the environment variable 'set' with an empty string value. If the configuration logic uses IsSet(key) to determine whether to use a default value, it will see the empty string as a user-provided value rather than falling back to the default. This may lead to unexpected behavior in tests that expect a 'nil' or 'unset' state to trigger default logic. func IsolateEnvironmentForTest(t *testing.T, keys ...string) { t.Helper() toClear := keys if len(toClear) == 0 { toClear = KnownLeakEnvironmentKeys } for _, k := range toClear { if k == "" { continue } t.Setenv(k, "") }

📚 Repository Context Analyzed This review considered 4 relevant code sections from 4 files (average relevance: 0.89) pkg/mocks/configuration.go (lines 1-224) pkg/configuration/configuration.go (lines 1-269) pkg/mocks/networking.go (lines 1-213) pkg/configtest/env.go (lines 1-33)