feat: preloading in audio tag#1075
Open
mdydek wants to merge 4 commits into
Open
Conversation
closetcaiman
requested changes
May 19, 2026
Contributor
closetcaiman
left a comment
closetcaiman
left a comment
There was a problem hiding this comment.
nice!
I'm not a fan of the current state of Audio.tsx. Maybe we can consider refactoring it for readability in the future?
closetcaiman
requested changes
May 21, 2026
Contributor
closetcaiman
left a comment
closetcaiman
left a comment
There was a problem hiding this comment.
Small nitpicks. JD overall!
Comment on lines
+200
to
+203
| template <typename T> | ||
| concept Decoder = std::is_base_of_v<decoding::IncrementalAudioDecoder, T>; | ||
|
|
||
| template <Decoder D> |
Contributor
There was a problem hiding this comment.
Suggested change
| template <typename T> | |
| concept Decoder = std::is_base_of_v<decoding::IncrementalAudioDecoder, T>; | |
| template <Decoder D> | |
| template <typename D> | |
| requires std::is_base_of_v<decoding::IncrementalAudioDecoder, D> |
Comment on lines
+23
to
+25
| auto duration = std::optional<double>(); | ||
| duration = | ||
| audiodecoding::probeDuration<miniaudio_decoder::MiniAudioDecoder>(data, size, sampleRate); |
Contributor
There was a problem hiding this comment.
Suggested change
| auto duration = std::optional<double>(); | |
| duration = | |
| audiodecoding::probeDuration<miniaudio_decoder::MiniAudioDecoder>(data, size, sampleRate); | |
| auto duration = | |
| audiodecoding::probeDuration<miniaudio_decoder::MiniAudioDecoder>(data, size, sampleRate); |
| ): Promise<number | null> { | ||
| return this.fileUtils.probeDuration(data, sampleRate); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Is this used anywhere else? I think it can be safely removed and the fetching line can be moved to probeDuration. Also, remember to use await here.
Contributor
There was a problem hiding this comment.
Ughh, the line selection was cut. The full function is:
public async probeDurationInstance(
data: ArrayBuffer,
sampleRate?: number
): Promise<number | null> {
return await this.fileUtils.probeDuration(data, sampleRate);
}
Comment on lines
+20
to
29
| const normalizedPreload = props.preload || 'auto'; | ||
|
|
||
| return { | ||
| ...props, | ||
| autoPlay: props.autoPlay ?? false, | ||
| controls: props.controls ?? false, | ||
| loop: props.loop ?? false, | ||
| muted: props.muted ?? false, | ||
| preload: props.preload ?? 'auto', | ||
| preload: normalizedPreload, | ||
| source: props.source ?? [], |
Contributor
There was a problem hiding this comment.
Suggested change
| const normalizedPreload = props.preload || 'auto'; | |
| return { | |
| ...props, | |
| autoPlay: props.autoPlay ?? false, | |
| controls: props.controls ?? false, | |
| loop: props.loop ?? false, | |
| muted: props.muted ?? false, | |
| preload: props.preload ?? 'auto', | |
| preload: normalizedPreload, | |
| source: props.source ?? [], | |
| return { | |
| ...props, | |
| autoPlay: props.autoPlay ?? false, | |
| controls: props.controls ?? false, | |
| loop: props.loop ?? false, | |
| muted: props.muted ?? false, | |
| preload: props.preload || 'auto', | |
| source: props.source ?? [], |
Comment on lines
+54
to
+55
| const preloadMode: PreloadType = | ||
| preload === 'none' || preload === 'metadata' ? preload : 'auto'; |
Contributor
There was a problem hiding this comment.
Is this even necessary if we use useStableAudioProps?
Comment on lines
+583
to
+585
| std::optional<double> FFmpegDecoder::probeDuration(const void *, size_t, int) { | ||
| return std::nullopt; | ||
| } |
Contributor
There was a problem hiding this comment.
This is not defined in the header. What is this for?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Introduced changes
Checklist