Feat/foreground service notifications #802
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poneciak57
commented
Nov 13, 2025
…re-mansion/react-native-audio-api into feat/fs_android_recording
michalsek
approved these changes
Nov 21, 2025
Member
michalsek
left a comment
michalsek
left a comment
There was a problem hiding this comment.
Small nitpicks, but overall great job, thanks for this! :)
packages/audiodocs/docs/system/playback-notification-manager.mdx
Outdated
Show resolved
Hide resolved
packages/audiodocs/docs/system/recording-notification-manager.mdx
Outdated
Show resolved
Hide resolved
...-native-audio-api/android/src/main/java/com/swmansion/audioapi/system/MediaSessionManager.kt
Outdated
Show resolved
Hide resolved
...id/src/main/java/com/swmansion/audioapi/system/notification/ForegroundNotificationService.kt
Outdated
Show resolved
Hide resolved
...pi/android/src/main/java/com/swmansion/audioapi/system/notification/RecordingNotification.kt
Outdated
Show resolved
Hide resolved
...pi/android/src/main/java/com/swmansion/audioapi/system/notification/RecordingNotification.kt
Show resolved
Hide resolved
...pi/android/src/main/java/com/swmansion/audioapi/system/notification/RecordingNotification.kt
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/src/web-system/notification/RecordingNotificationManager.ts
Outdated
Show resolved
Hide resolved
maciejmakowski2003
requested changes
Nov 25, 2025
Collaborator
maciejmakowski2003
left a comment
maciejmakowski2003
left a comment
There was a problem hiding this comment.
beside a few nitpicks, really great work!!! fingers crossed that it works as well as android code looks 🙃
apps/common-app/src/examples/PlaybackNotification/PlaybackNotification.tsx
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/ios/audioapi/ios/system/notification/PlaybackNotification.mm
Show resolved
Hide resolved
mdydek
requested changes
Nov 25, 2025
packages/react-native-audio-api/src/specs/NativeAudioAPIModule.ts
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/ios/audioapi/ios/system/notification/NotificationRegistry.mm
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/ios/audioapi/ios/system/notification/PlaybackNotification.mm
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/src/specs/NativeAudioAPIModule.ts
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/src/system/notification/RecordingNotificationManager.ts
Show resolved
Hide resolved
...ct-native-audio-api/android/src/main/java/com/swmansion/audioapi/system/LockScreenManager.kt
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/ios/audioapi/ios/system/notification/PlaybackNotification.mm
Show resolved
Hide resolved
packages/react-native-audio-api/ios/audioapi/ios/system/notification/PlaybackNotification.mm
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/ios/audioapi/ios/system/notification/PlaybackNotification.mm
Show resolved
Hide resolved
maciejmakowski2003
requested changes
Nov 28, 2025
...-native-audio-api/android/src/main/java/com/swmansion/audioapi/system/MediaSessionManager.kt
Show resolved
Hide resolved
michalsek
approved these changes
Dec 1, 2025
mdydek
requested changes
Dec 4, 2025
Contributor
mdydek
left a comment
mdydek
left a comment
There was a problem hiding this comment.
add to docs mention about small icon on android
mdydek
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💀
Closes RNAA-310
Closes #820
TODO
Maybe TODO
NotificationReceiver for notification dissmised event can be centralized right now there are two receivers(not wanted)AudioManageryou should usePlaybackNotificationManagerIntroduced changes
RecordingNotificationManagerfor management of notification dedicated for recordingPlaybackNotificationManagerfor management of notification dedicated for playbackAudioManagerChecklist