-
-
Notifications
You must be signed in to change notification settings - Fork 65
feat: Graph refactor chapter II #991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
poneciak57
wants to merge
60
commits into
main
Choose a base branch
from
feat/graph_refactor_2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
60 commits
Select commit
Hold shift + click to select a range
8274a95
feat: added base GraphObject
poneciak57 b4625aa
feat: integrated new memory disposer
maciejmakowski2003 a010057
feat: added bridge node
poneciak57 d9d1791
fix: changed from shared_ptr to using unique_ptr for singly owned com…
poneciak57 fa4d2f0
Merge branch 'feat/graph_refactor_2' into feat/integrate-new-memory-d…
poneciak57 52d274d
feat: moved disposer out of graph class
poneciak57 92b9b3c
Merge branch 'main' into feat/graph_refactor_2
maciejmakowski2003 c607534
refactor: template nitpick
maciejmakowski2003 971bf36
refactor: update AudioNodeHostObject to use Graph and HostNode
maciejmakowski2003 8efcef4
test: fix tests to use std::make_shared instead of context factory me…
maciejmakowski2003 7d2d876
refactor: nitpicks
maciejmakowski2003 2a525b9
refactor: first part of integration
maciejmakowski2003 98e76f2
ci: yarn format
maciejmakowski2003 08a5ee2
refactor: added separate input and output buffers getters to satisfy …
maciejmakowski2003 3265b23
refactor: destination ownership and connection logic
maciejmakowski2003 f151efa
ci: yarn format
maciejmakowski2003 bc8c628
refactor: disconnect all outputs from a node
maciejmakowski2003 ebffe07
refactor: destination node initialization and ownership
maciejmakowski2003 bd4637c
ci: yarn format
maciejmakowski2003 c9cfa78
refactor: added param owner node
maciejmakowski2003 9b984c5
fix: fixed my processor node implementation in the guide and template
maciejmakowski2003 b6adf6c
refactor: removed isInitialized and added overrides for canBeDestructed
maciejmakowski2003 22c5b5f
feat: bridge audio param to graph
poneciak57 5994a64
Merge branch 'main' into feat/graph_refactor_2
maciejmakowski2003 a7a0fc4
ci: yarn format
maciejmakowski2003 43a7395
fix: fixed removeAllEdges
maciejmakowski2003 2952e5e
refactor: cleanup
maciejmakowski2003 1888507
fix: nitpicks
maciejmakowski2003 88f506c
refactor: lazy bridge node creation for AudioParamHostObject
maciejmakowski2003 4db7657
refactor: trigger disposing of ghost nodes on context state changes
maciejmakowski2003 f12fb88
refactor: bring back recorder connect with recorder adapter
maciejmakowski2003 a985577
ci: format
maciejmakowski2003 d7f53d1
refactor: implemented disable() for AudioBufferSourceNode to dispose …
maciejmakowski2003 cb9d312
fix: fixed allocation when adding nodes
poneciak57 3024c99
fix: convolver initialization
mdydek 465ebe3
refactor: removed .hpp files
mdydek bbb909f
feat: delay node
mdydek ccd40a7
feat: enabling delay both nodes
mdydek 6a71c9c
feat: channel count negotiations
mdydek e9168ab
Merge branch 'main' into feat/graph_refactor_2
mdydek 0e3967e
feat: removed race conditions
mdydek 0578d53
Merge branch 'main' into feat/graph_refactor_2
mdydek f9c7872
feat: tail time handling
mdydek ccda0ad
feat: fully working tail time
mdydek f0037aa
test: fix
mdydek 58029c1
feat: remove recorder adapter from api
mdydek 351657e
refactor: memory pressure
mdydek 093a860
test: fix sync between gc and js queues
mdydek cd39a39
refactor: unnecesary code cleanup
mdydek 07c148b
feat: allocation guard
mdydek 0e77def
feat: convolver no allocations
mdydek 44e1f87
Merge branch 'main' into feat/graph_refactor_2
mdydek 4e23f14
feat: no allocations streamer
mdydek 35a2305
feat: no allocations wave shaper
mdydek ebab432
Merge branch 'main' into feat/graph_refactor_2
mdydek d1f1e09
feat: removed inplace function
mdydek cd94921
feat: added necessary header
mdydek 0c7abaa
feat: less strict alloc guard
mdydek 122ccd0
Merge branch 'main' into feat/graph_refactor_2
mdydek ae8de4f
feat: more informative thread pool
mdydek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just checking in
is it possible to call start and stop concurently (eg at the same time)?