Skip to content

fix: setting mention without indicator typed #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kacperzolkiewski wants to merge 2 commits into
base: main
Choose a base branch
from
+15 −10
Open

fix: setting mention without indicator typed #606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85a1249
fix: setting mention withoout indicator typed
kacperzolkiewski May 15, 2026
de518f4
fix(android): setting mention without indicator typed
kacperzolkiewski May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion android/src/main/java/com/swmansion/enriched/textinput/styles/ParametrizedStyles.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ class ParametrizedStyles(
spannable.removeSpan(span)
}

val start = mentionStart ?: return
val start = mentionStart ?: selectionStart

view.runAsATransaction {
spannable.replace(start, selectionEnd, text)
Expand All @@ -383,6 +383,7 @@ class ParametrizedStyles(

view.mentionHandler?.reset()
view.selection.validateStyles()
mentionStart = null
Copy link
Copy Markdown
Collaborator

@exploIF exploIF May 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you clarify why it's needed?

Copy link
Copy Markdown
Collaborator Author

@kacperzolkiewski kacperzolkiewski May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without setting mentionStart to null, the value is never reset. As a result, when a mention is first added by typing @ and then another one is inserted manually via setMention, mentionStart still points to the position of the first typed mention, which is incorrect.

Screen.Recording.2026-05-18.at.10.26.15.mov

}

fun getStyleRange(): Pair<Int, Int> = view.selection?.getInlineSelection() ?: Pair(0, 0)
Expand Down
16 changes: 8 additions & 8 deletions ios/EnrichedTextInputView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1479,15 +1479,15 @@ - (void)addMention:(NSString *)indicator
if (mentionStyleClass == nullptr) {
return;
}
if ([mentionStyleClass getActiveMentionRange] == nullptr) {
return;
}

if ([StyleUtils
handleStyleBlocksAndConflicts:[MentionStyle getType]
range:[[mentionStyleClass
getActiveMentionRange] rangeValue]
forHost:self]) {
NSValue *activeMentionRange = [mentionStyleClass getActiveMentionRange];
NSRange rangeToUse = activeMentionRange != nullptr
? [activeMentionRange rangeValue]
: self.textView.selectedRange;

if ([StyleUtils handleStyleBlocksAndConflicts:[MentionStyle getType]
range:rangeToUse
forHost:self]) {
[mentionStyleClass addMention:indicator text:text attributes:attributes];
[self anyTextMayHaveBeenModified];
}
Expand Down
6 changes: 5 additions & 1 deletion ios/styles/MentionStyle.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,11 @@ - (void)addMention:(NSString *)indicator
text:(NSString *)text
attributes:(NSString *)attributes {
if (_activeMentionRange == nullptr) {
return;
// No draft mention (indicator not typed) - fall back to the current
// selection.
_activeMentionRange =
[NSValue valueWithRange:self.host.textView.selectedRange];
_activeMentionIndicator = indicator;
}

_blockMentionEditing = YES;
Expand Down
Loading