Conversation
benITo47
force-pushed
the
@bo/SwapBinaries
branch
from
ebbb487 to
07c9fbd
Compare
mkopcins
approved these changes
Feb 11, 2026
Member
|
I had an error in Clip embedding example: |
msluszniak
approved these changes
Feb 11, 2026
Member
msluszniak
left a comment
msluszniak
left a comment
There was a problem hiding this comment.
I ran tests and tested all demo apps using tokenizers. All worked as expected :))
benITo47
added a commit
that referenced
this pull request
Feb 12, 2026
## Description This PR changes binaries to include new tokenizer functionalities. Added: - Wordpiece model and decoder - Bert and Roberta tokenization is supported - Padding and truncation from tokenizer.json is now respected ### Introduces a breaking change? - [ ] Yes - [x] No ### Type of change - [x] Bug fix (change which fixes an issue) - [ ] New feature (change which adds functionality) - [ ] Documentation update (improves or adds clarity to existing documentation) - [ ] Other (chores, tests, code style improvements etc.) ### Tested on - [x] iOS - [x] Android ### Testing instructions Run the test suites. Run all apps that use tokenizers and verify they load and produce proper output (LLM, S2T, T2I, Embeddings etc.) ### Checklist - [x] I have performed a self-review of my code ### Additional notes Running the tests can yield some issues. Couldn't get to why they happen. Calling failing functions in example apps yields proper results. Probably some issue with test environment. We decided to not hold this PR due to failing TC's and investigate them later on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes binaries to include new tokenizer functionalities.
Added:
Introduces a breaking change?
Type of change
Tested on
Testing instructions
Run the test suites.
Run all apps that use tokenizers and verify they load and produce proper output (LLM, S2T, T2I, Embeddings etc.)
Checklist
Additional notes
Runnin the tests can yield some issues. Couldn't get to why they happen. Calling failing functions in example apps yields proper results. Probably some issue with test environment. We decided to not hold this PR due to those failing TC's and investigate them later on.