Skip to content

build: build with executorch 1.1 (#765)#806

Merged
IgorSwat merged 3 commits intomainfrom
@is/build-with-1.1
Feb 13, 2026
Merged

build: build with executorch 1.1 (#765)#806
IgorSwat merged 3 commits intomainfrom
@is/build-with-1.1

Conversation

@IgorSwat
Copy link
Contributor

@IgorSwat IgorSwat commented Feb 12, 2026

Description

Bumped ExecuTorch binaries & headers to 1.1.0 version of the package.

Introduces a breaking change?

  • Yes
  • No

Type of change

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Documentation update (improves or adds clarity to existing documentation)
  • Other (chores, tests, code style improvements etc.)

Tested on

  • iOS
  • Android

Testing instructions

Run all the test from packages/react-native-executorch/common/rnexecutorch/tests and verify the correctness of all models (except Speech-to-Text, see the Additional notes section).

Screenshots

Related issues

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings

Additional notes

I tested most of the models on both Android & iOS platforms. The only 'broken' model seems to be Speech To Text Encoder - but this one will be fixed in the incoming STT fix PR.

Copy link
Member

@msluszniak msluszniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No testing instructions provided. This disqualifies the PR even for a review.

@IgorSwat
Copy link
Contributor Author

No testing instructions provided. This disqualifies the PR even for a review.

Is it fine now :)?

@msluszniak
Copy link
Member

Is it fine now :)?

Perfect, I'm on it :)

@msluszniak msluszniak self-requested a review February 12, 2026 14:05
@msluszniak
Copy link
Member

During test run I spotted that I make a mistake in STT test. Could you change this line:

from transcription to transcribe?

@msluszniak
Copy link
Member

msluszniak commented Feb 12, 2026

Could you also change in this line:

textContent={`Loading the model ${(llm.downloadProgress * 100).toFixed(0)} %\nLoading the speech model ${(speechToText.downloadProgress * 100).toFixed(0)} %`}

Loading the model ${(llm.downloadProgress * 100).toFixed(0)} ... to Loading the LLM model ${(llm.downloadProgress * 100).toFixed(0)}...

@msluszniak
Copy link
Member

Ok, I tested all the apps works as previously. If you apply this two nits, then I'm good to ship it :))

@msluszniak msluszniak added executorch Issues and tasks related specifically to ExecuTorch chore PRs that are chores labels Feb 13, 2026
@msluszniak msluszniak linked an issue Feb 13, 2026 that may be closed by this pull request
@IgorSwat
Copy link
Contributor Author

Ok, I tested all the apps works as previously. If you apply this two nits, then I'm good to ship it :))

Done.

@IgorSwat IgorSwat merged commit 1b7363d into main Feb 13, 2026
4 of 5 checks passed
@IgorSwat IgorSwat deleted the @is/build-with-1.1 branch February 13, 2026 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore PRs that are chores executorch Issues and tasks related specifically to ExecuTorch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build with ExecuTorch 1.1

2 participants