[iOS] Ignore Apple's default retention offset for buttons and rely strictly on hitslop instead#4038
Open
j-piasecki wants to merge 2 commits intomainfrom
Open
[iOS] Ignore Apple's default retention offset for buttons and rely strictly on hitslop instead#4038j-piasecki wants to merge 2 commits intomainfrom
j-piasecki wants to merge 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts iOS UIControl touch-tracking for RNGestureHandlerButton to ignore Apple’s default “retention offset” behavior and instead base drag/up-inside vs outside decisions strictly on the component’s hitSlop/hitTestEdgeInsets, improving consistency with shouldCancelWhenOutside.
Changes:
- Adds internal state to track whether the touch is currently inside the
hitSlop-adjusted bounds. - Overrides
continueTrackingWithTouchto generate drag enter/exit and drag inside/outside events using strict bounds checks (bypassingUIControl’s default behavior). - Overrides
endTrackingWithTouchto sendTouchUpInsidevsTouchUpOutsidebased on strict bounds checks.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/react-native-gesture-handler/apple/RNGestureHandlerButton.mm
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Apple enforces a stupidly large retention offset in the default UIControl touch tracking loop, which was conflicting with
shouldCancelWhenOutsideandhitSlopprops. This PR overrides the default tracking loop to rely only on our props instead.Test plan
Tested on the example added in #4018