[MPT-18516] Update workflow e2e test step to continue on failure to not block actions

[robcsegal]

This pull request makes a minor adjustment to the CI workflow configuration for end-to-end (E2E) tests. The main change is allowing E2E test steps to continue on error rather than fail the entire workflow.

Most important changes:

Workflow reliability improvements:

• .github/workflows/push-release-branch.yml and .github/workflows/release.yml: Added continue-on-error: true to the "Run E2E test" job steps to prevent workflow failure if E2E tests fail. [1] [2]

Closes MPT-18516

• Add continue-on-error: true to the "Run E2E test" step in .github/workflows/push-release-branch.yml so the workflow continues if E2E tests fail
• Add continue-on-error: true to the "Run E2E test" step in .github/workflows/release.yml so the workflow continues if E2E tests fail

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d3430fd and f247617.

📒 Files selected for processing (2)

• .github/workflows/push-release-branch.yml
• .github/workflows/release.yml

🚧 Files skipped from review as they are similar to previous changes (2)

• .github/workflows/push-release-branch.yml
• .github/workflows/release.yml

---

📝 Walkthrough

Walkthrough

Two GitHub Actions workflow files were modified to add continue-on-error: true to their "Run E2E test" steps so workflows continue even if E2E tests fail.

Changes

Cohort / File(s)	Summary
E2E Test Error Continuity .github/workflows/push-release-branch.yml, .github/workflows/release.yml	Added continue-on-error: true to the "Run E2E test" step in both workflows.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• softwareone-platform/mpt-api-python-client#193 — Related change to PR workflow E2E handling (this PR makes the E2E step continue-on-error; that PR removes the step).

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Jira Issue Key In Title	✅ Passed	The PR title contains exactly one Jira issue key MPT-18516 in the correct format at the beginning.
Test Coverage Required	✅ Passed	The PR includes 325 test files added along with 133 code files in the mpt_api_client directory, providing comprehensive test coverage.
Single Commit Required	✅ Passed	The PR contains exactly one commit that consolidates all necessary changes to both workflow files by adding continue-on-error: true to E2E test steps.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

.github/workflows/release.yml (1)

38-38: Surface E2E test failures explicitly in release runs.

The E2E test at line 37–44 uses continue-on-error: true, allowing the workflow to proceed to publishing even if tests fail. Without explicit visibility, E2E failures can go unnoticed in release runs.

Add a step id to the E2E step and include a warning step that surfaces failures:

Proposed addition

     - name: "Run E2E test"
+      id: e2e
       continue-on-error: true
       run: make e2e args="--reportportal --rp-launch=$RP_LAUNCH --rp-api-key=$RP_API_KEY --rp-endpoint=$RP_ENDPOINT -o rp_launch_attributes=\"$RP_LAUNCH_ATTR\""
       env:
         RP_LAUNCH: mpt-api-client-e2e
         RP_ENDPOINT: ${{ secrets.RP_ENDPOINT }}
         RP_API_KEY: ${{ secrets.RP_API_KEY }}
         RP_LAUNCH_ATTR: ref:${{ github.ref }} event_name:${{ github.event_name }}

+    - name: "Warn when E2E fails"
+      if: steps.e2e.outcome == 'failure'
+      run: |
+        echo "::warning title=E2E failed::Release continued because continue-on-error is enabled."
+        echo "⚠️ E2E failed in this release workflow run." >> "$GITHUB_STEP_SUMMARY"

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.github/workflows/release.yml at line 38, Add an id to the E2E step (e.g.,
id: e2e) and add a follow-up step that checks the E2E step outcome and surfaces
a warning when it failed; specifically, keep continue-on-error: true on the E2E
step but add a subsequent step that uses if: steps.e2e.outcome != 'success' and
runs a short command to emit a conspicuous warning (for example an echo or
GitHub Actions logging command) referencing the e2e step and linking to logs so
E2E failures are explicitly visible in release runs.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.github/workflows/release.yml:
- Line 38: Add an id to the E2E step (e.g., id: e2e) and add a follow-up step
that checks the E2E step outcome and surfaces a warning when it failed;
specifically, keep continue-on-error: true on the E2E step but add a subsequent
step that uses if: steps.e2e.outcome != 'success' and runs a short command to
emit a conspicuous warning (for example an echo or GitHub Actions logging
command) referencing the e2e step and linking to logs so E2E failures are
explicitly visible in release runs.

---

ℹ️ Review info

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 878b327 and d3430fd.

📒 Files selected for processing (2)

• .github/workflows/push-release-branch.yml
• .github/workflows/release.yml

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud