Add Perspective tests and general refactor#368
Merged
SteveChurchillSWO merged 2 commits intomainfrom Mar 5, 2026
Merged
Conversation
Move filter-related locators and helper methods from BaseCreatePage and ResourcesPage into BasePage to centralize filter handling and avoid duplication. Add numerous utility improvements and documentation in BasePage (viewport fitting, getByAnyTestId, combo-box helpers, enhanced canvas waiters, aria/bringToFront helpers, screenshot delay, reset/select filter helpers and getActiveFilter). Update ResourcesPage to use centralized filters and add perspectives/save-perspective locators and helpers (navigation, reset, meta selectors, group-by/tag helpers). Add CloudAccounts navigation helper, refine tab-click logic to avoid redundant clicks and wait for canvases/progress bars, and expand PerspectivesPage with row selection, deletion and bulk-delete utilities. Remove the now-unneeded CreateAnomalyPage and a couple of redundant page methods to reduce duplication.
Add explicit progress-bar waits and minor test improvements to reduce flakiness. Changes include: - Call waitForAllProgressBarsToDisappear after deleting perspectives in PerspectivesPage. - Add a detailed JSDoc for ResourcesPage.navigateToResourcesPageAndResetFilters describing its behavior (navigate to /resources, wait for progress bars, canvas render, reset filters, and wait for first resource item — 15s timeout) and recommending its use in beforeEach to get a clean state. - Update a test title capitalization and add a test step to return to the resources page and reset filters between perspective operations. - Add waitForAllProgressBarsToDisappear before deleting all perspectives in the perspective cleanup step. These changes aim to stabilize E2E tests by ensuring pages are fully loaded and filters are reset before interacting with UI elements.
dwolosz
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move filter-related locators and helper methods from BaseCreatePage and ResourcesPage into BasePage to centralize filter handling and avoid duplication. Add numerous utility improvements and documentation in BasePage (viewport fitting, getByAnyTestId, combo-box helpers, enhanced canvas waiters, aria/bringToFront helpers, screenshot delay, reset/select filter helpers and getActiveFilter). Update ResourcesPage to use centralized filters and add perspectives/save-perspective locators and helpers (navigation, reset, meta selectors, group-by/tag helpers). Add CloudAccounts navigation helper, refine tab-click logic to avoid redundant clicks and wait for canvases/progress bars, and expand PerspectivesPage with row selection, deletion and bulk-delete utilities. Remove the now-unneeded CreateAnomalyPage and a couple of redundant page methods to reduce duplication.
Related issue number
https://softwareone.atlassian.net/browse/MPT-18579