Update links referring to master branch in README#439
Open
Update links referring to master branch in README#439
Conversation
sol
requested changes
Jul 29, 2021
Owner
sol
left a comment
sol
left a comment
There was a problem hiding this comment.
Hey! Nice catch. Some of the repos did not change. Can you help with fixing this?
| * Given this [package.yaml](https://github.com/hspec/sensei/blob/master/package.yaml) running `hpack` will generate [sensei.cabal](https://github.com/hspec/sensei/blob/master/sensei.cabal) | ||
| * Given this [package.yaml](https://github.com/haskell-compat/base-orphans/blob/master/package.yaml) running `hpack` will generate [base-orphans.cabal](https://github.com/haskell-compat/base-orphans/blob/master/base-orphans.cabal) | ||
| * Given this [package.yaml](https://github.com/sol/hpack/blob/main/package.yaml) running `hpack` will generate [hpack.cabal](https://github.com/sol/hpack/blob/main/hpack.cabal) | ||
| * Given this [package.yaml](https://github.com/zalora/getopt-generics/blob/main/package.yaml) running `hpack` will generate [getopt-generics.cabal](https://github.com/zalora/getopt-generics/blob/main/getopt-generics.cabal) |
Owner
There was a problem hiding this comment.
This repo still uses master, albeit the repo itself mas moved to https://github.com/soenkehahn/getopt-generics/.
| * Given this [package.yaml](https://github.com/sol/hpack/blob/main/package.yaml) running `hpack` will generate [hpack.cabal](https://github.com/sol/hpack/blob/main/hpack.cabal) | ||
| * Given this [package.yaml](https://github.com/zalora/getopt-generics/blob/main/package.yaml) running `hpack` will generate [getopt-generics.cabal](https://github.com/zalora/getopt-generics/blob/main/getopt-generics.cabal) | ||
| * Given this [package.yaml](https://github.com/hspec/sensei/blob/main/package.yaml) running `hpack` will generate [sensei.cabal](https://github.com/hspec/sensei/blob/main/sensei.cabal) | ||
| * Given this [package.yaml](https://github.com/haskell-compat/base-orphans/blob/main/package.yaml) running `hpack` will generate [base-orphans.cabal](https://github.com/haskell-compat/base-orphans/blob/main/base-orphans.cabal) |
Owner
There was a problem hiding this comment.
I think this repo still uses master as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While attempting to install
hpackfrom the link referred to in the README:So, I figured I'd just do a quick string replace and submit a PR. It's just a quick edit and I haven't done any of the usual prerequisite legwork like checking to see if this duplicates work in an existing PR or anything, so feel free to completely disregard this PR and close it if it's not helpful ;)