improve layer build#207
Conversation
cheempz
left a comment
There was a problem hiding this comment.
Thanks for the revisit @xuan-cao-swi! I think it's all working, but there could a few more improvements. The main one i'll actually describe here:
Right now we're hardcoding and peppering in various places the ruby version, which can get easily out of sync. How about making the versions a workflow variable that's easily visible and changed in once place?
Updated to use single env variable from github action file that define all ruby version. |
cheempz
left a comment
There was a problem hiding this comment.
LGTM, thanks for the revisit @xuan-cao-swi!
|
Actually, running into an issue when i tried the |
My bad only saw the changes from a single commit
Description
Test (if applicable)
Layer building succeeded (action).
Tested on aws lambda.