NH-132896: increase test coverage#254
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
RuboCop found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Contributor
|
@xuan-cao-swi any way to easily see the coverage info? Quick check there seem to be GHA integrations available. |
Contributor
Author
Yeah, I integrated the codecov.io |
cheempz
reviewed
Mar 24, 2026
Contributor
cheempz
left a comment
cheempz
left a comment
There was a problem hiding this comment.
Overall i like the improvements on test description and coverage, but from spot-checking what tests are actually doing, there are gaps between what descriptions say are being tested and actual setup/assertions.
cheempz
reviewed
Mar 24, 2026
cheempz
reviewed
Mar 30, 2026
cheempz
reviewed
Mar 30, 2026
cheempz
reviewed
Mar 30, 2026
cheempz
reviewed
Mar 30, 2026
cheempz
reviewed
Mar 30, 2026
cheempz
reviewed
Mar 30, 2026
cheempz
reviewed
Mar 31, 2026
cheempz
reviewed
Mar 31, 2026
cheempz
reviewed
Apr 1, 2026
cheempz
reviewed
Apr 1, 2026
cheempz
reviewed
Apr 1, 2026
cheempz
reviewed
Apr 1, 2026
cheempz
reviewed
Apr 1, 2026
cheempz
reviewed
Apr 1, 2026
cheempz
reviewed
Apr 1, 2026
cheempz
reviewed
Apr 1, 2026
cheempz
reviewed
Apr 1, 2026
cheempz
reviewed
Apr 1, 2026
cheempz
reviewed
Apr 1, 2026
cheempz
reviewed
Apr 1, 2026
Co-authored-by: Lin Lin <lin.lin@solarwinds.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Test (if applicable)